Commit 0f5df8e1 authored by unknown's avatar unknown
Browse files

BUG#17455: Wrong results from Repair/Optimize .. table for partitioned tables 


mysql-test/r/partition.result:
  New test case
mysql-test/t/partition.test:
  New test case
sql/ha_partition.cc:
  Fixed error handling
parent 19b40124

mysql-test/r/partition.result

+10 −0
Original line number Diff line number Diff line
@@ -886,4 +886,14 @@ s1 
2

3

drop table t1;

create table t1 (a int)

engine=MEMORY

partition by key (a);

REPAIR TABLE t1;

Table	Op	Msg_type	Msg_text

test.t1	repair	note	The storage engine for the table doesn't support repair

OPTIMIZE TABLE t1;

Table	Op	Msg_type	Msg_text

test.t1	optimize	note	The storage engine for the table doesn't support optimize

drop table t1;

End of 5.1 tests

mysql-test/t/partition.test

+13 −0
Original line number Diff line number Diff line
@@ -1009,4 +1009,17 @@ select auto_increment from information_schema.tables where table_name='t1'; 
select * from t1;

drop table t1;



#

# Bug 17455 Partitions: Wrong message and error when using Repair/Optimize

#                       table on partitioned table

#

create table t1 (a int)

engine=MEMORY

partition by key (a);



REPAIR TABLE t1;

OPTIMIZE TABLE t1;



drop table t1;



--echo End of 5.1 tests

sql/ha_partition.cc

+2 −4
Original line number Diff line number Diff line
@@ -1108,8 +1108,7 @@ int ha_partition::handle_opt_partitions(THD *thd, HA_CHECK_OPT *check_opt, 
                     part));

          if ((error= handle_opt_part(thd, check_opt, m_file[part], flag)))

          {

            my_error(ER_GET_ERRNO, MYF(0), error);

            DBUG_RETURN(TRUE);

            DBUG_RETURN(error);

          }

        } while (++j < no_subparts);

      }
@@ -1118,8 +1117,7 @@ int ha_partition::handle_opt_partitions(THD *thd, HA_CHECK_OPT *check_opt, 
        DBUG_PRINT("info", ("Optimize partition %u", i));

        if ((error= handle_opt_part(thd, check_opt, m_file[i], flag)))

        {

          my_error(ER_GET_ERRNO, MYF(0), error);

          DBUG_RETURN(TRUE);

          DBUG_RETURN(error);

        }

      }

    }