Commit 11cd97ed authored by gkodinov/kgeorge@magare.gmz's avatar gkodinov/kgeorge@magare.gmz
Browse files

Bug #34909: mysqldump returns a 0 status on error when using 

  --master-data

No error code was returned by mysqldump if it detects that binary
logging is not enabled on the server.
Fixed by returning error code.
parent 0596b1c6

client/mysqldump.c

+1 −0
Original line number Diff line number Diff line
@@ -3285,6 +3285,7 @@ static int do_show_master_status(MYSQL *mysql_con) 
      my_printf_error(0, "Error: Binlogging on server not active",

                      MYF(0));

      mysql_free_result(master);

      maybe_exit(EX_MYSQLERR);

      return 1;

    }

    mysql_free_result(master);

mysql-test/r/mysqldump-no-binlog.result

0 → 100644
+1 −0
Original line number Diff line number Diff line 
mysqldump: Error: Binlogging on server not active

mysql-test/t/mysqldump-no-binlog-master.opt

0 → 100644
+1 −0
Original line number Diff line number Diff line 
--skip-log-bin

mysql-test/t/mysqldump-no-binlog.test

0 → 100644
+6 −0
Original line number Diff line number Diff line 
# Embedded server doesn't support external clients

--source include/not_embedded.inc



--replace_regex /MASTER_LOG_POS=[0-9]+/XX/

--error 2

--exec $MYSQL_DUMP --compact --master-data=2 test 2>&1