Commit 144c873e authored by monty@mysql.com's avatar monty@mysql.com
Browse files

Review of new pushed code 

- No need to check *ref when ref is checked (Simple optimization fix)
parent 58c64aea

sql/item.cc

+2 −2
Original line number Diff line number Diff line
@@ -352,7 +352,7 @@ bool Item_field::fix_fields(THD *thd,TABLE_LIST *tables) 
      if (thd->lex.select_lex.is_item_list_lookup)

      {

        Item **res= find_item_in_list(this, thd->lex.select_lex.item_list);

        if (res && *res && (*res)->type() == Item::FIELD_ITEM)

        if (res && (*res)->type() == Item::FIELD_ITEM)

        {

          set_field((*((Item_field**)res))->field);

          return 0;