Commit 199a1672 authored by mhansson/martin@linux-st28.site's avatar mhansson/martin@linux-st28.site
Browse files

Bug#31797: error while parsing subqueries -- WHERE is parsed as HAVING 

The name resolution for correlated subqueries and HAVING clauses
failed to distinguish which of two was being performed when there 
was a reference to an outer aliased field.
Fixed by adding the condition that HAVING clause name resulotion
is being performed.
parent 7f67efcc

mysql-test/r/group_by.result

+36 −0
Original line number Diff line number Diff line
@@ -1113,3 +1113,39 @@ c b 
3	1

3	2

DROP TABLE t1;

CREATE TABLE t1 ( a INT, b INT );

SELECT b c, (SELECT a FROM t1 WHERE b = c)

FROM t1;

c	(SELECT a FROM t1 WHERE b = c)

SELECT b c, (SELECT a FROM t1 WHERE b = c)

FROM t1 

HAVING b = 10;

c	(SELECT a FROM t1 WHERE b = c)

SELECT MAX(b) c, (SELECT a FROM t1 WHERE b = c)

FROM t1 

HAVING b = 10;

ERROR 42S22: Reference 'c' not supported (reference to group function)

SET @old_sql_mode = @@sql_mode;

SET @@sql_mode='ONLY_FULL_GROUP_BY';

SELECT b c, (SELECT a FROM t1 WHERE b = c)

FROM t1;

c	(SELECT a FROM t1 WHERE b = c)

SELECT b c, (SELECT a FROM t1 WHERE b = c)

FROM t1 

HAVING b = 10;

ERROR 42000: non-grouping field 'b' is used in HAVING clause

SELECT MAX(b) c, (SELECT a FROM t1 WHERE b = c)

FROM t1 

HAVING b = 10;

ERROR 42S22: Reference 'c' not supported (reference to group function)

INSERT INTO t1 VALUES (1, 1);

SELECT b c, (SELECT a FROM t1 WHERE b = c)

FROM t1;

c	(SELECT a FROM t1 WHERE b = c)

1	1

INSERT INTO t1 VALUES (2, 1);

SELECT b c, (SELECT a FROM t1 WHERE b = c)

FROM t1;

ERROR 21000: Subquery returns more than 1 row

DROP TABLE t1;

SET @@sql_mode = @old_sql_mode;

mysql-test/t/group_by.test

+48 −0
Original line number Diff line number Diff line
@@ -815,3 +815,51 @@ EXPLAIN SELECT c,b FROM t1 GROUP BY c,b; 
SELECT c,b   FROM t1 GROUP BY c,b;



DROP TABLE t1;



#

# Bug #31797: error while parsing subqueries -- WHERE is parsed as HAVING

#

CREATE TABLE t1 ( a INT, b INT );



SELECT b c, (SELECT a FROM t1 WHERE b = c)

FROM t1;



SELECT b c, (SELECT a FROM t1 WHERE b = c)

FROM t1 

HAVING b = 10;



--error ER_ILLEGAL_REFERENCE

SELECT MAX(b) c, (SELECT a FROM t1 WHERE b = c)

FROM t1 

HAVING b = 10;



SET @old_sql_mode = @@sql_mode;

SET @@sql_mode='ONLY_FULL_GROUP_BY';



SELECT b c, (SELECT a FROM t1 WHERE b = c)

FROM t1;



--error ER_NON_GROUPING_FIELD_USED

SELECT b c, (SELECT a FROM t1 WHERE b = c)

FROM t1 

HAVING b = 10;



--error ER_ILLEGAL_REFERENCE

SELECT MAX(b) c, (SELECT a FROM t1 WHERE b = c)

FROM t1 

HAVING b = 10;



INSERT INTO t1 VALUES (1, 1);

SELECT b c, (SELECT a FROM t1 WHERE b = c)

FROM t1;



INSERT INTO t1 VALUES (2, 1);

--error ER_SUBQUERY_NO_1_ROW

SELECT b c, (SELECT a FROM t1 WHERE b = c)

FROM t1;



DROP TABLE t1;

SET @@sql_mode = @old_sql_mode;

sql/item.cc

+2 −1
Original line number Diff line number Diff line
@@ -3352,7 +3352,7 @@ static Item** find_field_in_group_list(Item *find_item, ORDER *group_list) 
    resolve_ref_in_select_and_group()

    thd     current thread

    ref     column reference being resolved

    select  the sub-select that ref is resolved against

    select  the select that ref is resolved against



  DESCRIPTION

    Resolve a column reference (usually inside a HAVING clause) against the
@@ -3423,6 +3423,7 @@ resolve_ref_in_select_and_group(THD *thd, Item_ident *ref, SELECT_LEX *select) 
  }



  if (thd->variables.sql_mode & MODE_ONLY_FULL_GROUP_BY &&

      select->having_fix_field  &&

      select_ref != not_found_item && !group_by_ref)

  {

    /*