Loading BitKeeper/etc/logging_ok +5 −4 Original line number Diff line number Diff line Administrator@co3064164-a. Administrator@co3064164-a.rochd1.qld.optushome.com.au Administrator@fred. Miguel@light.local Sinisa@sinisa.nasamreza.org ahlentz@co3064164-a.rochd1.qld.optusnet.com.au arjen@co3064164-a.bitbike.com davida@isil.mysql.com heikki@donna.mysql.fi jani@hynda.mysql.fi Loading @@ -13,6 +17,7 @@ monty@bitch.mysql.fi monty@donna.mysql.fi monty@hundin.mysql.fi monty@tik.mysql.fi monty@tramp.mysql.fi monty@work.mysql.com mwagner@evoq.mwagner.org paul@central.snake.net Loading @@ -31,7 +36,3 @@ tonu@hundin.mysql.fi tonu@volk.internalnet tonu@x153.internalnet tonu@x3.internalnet Administrator@co3064164-a. Administrator@co3064164-a.rochd1.qld.optushome.com.au ahlentz@co3064164-a.rochd1.qld.optusnet.com.au arjen@co3064164-a.bitbike.com Docs/internals.texi +18 −20 Original line number Diff line number Diff line Loading @@ -183,23 +183,27 @@ and then we read the rows in the sorted order into a row buffer We are using @uref{http://www.bitkeeper.com/, BitKeeper} for source management. @item You should use the @strong{MySQL} 3.23 or 4.0 source for all developments. You should use the @strong{MySQL} 4.0 source for all developments. @item If you have any questions about the @strong{MySQL} source, you can post these to @email{developers@@mysql.com} and we will answer them. Note that we will shortly change the name of this list to @email{internals@@mysql.com}, to more accurately reflect what should be posted to this list. to @email{dev-public@@mysql.com} and we will answer them. Please remember to not use this internal email list in public! @item Try to write code in a lot of black boxes that can be reused or at least have a clean interface. Try to write code in a lot of black boxes that can be reused or use at least a clean, easy to change interface. @item Reuse code; There is already a lot of algorithms in MySQL for list handling, queues, dynamic and hashed arrays, sorting, etc. that can be reused. @item Use the @code{my_*} functions like @code{my_read()}/@code{my_write()}/ @code{my_malloc()} that you can find in the @code{mysys} library instead of the direct system calls; This will make your code easier to debug and more portable. @item Try to always write optimized code, so that you don't have to go back and rewrite it a couple of months later. It's better to Loading @@ -222,7 +226,11 @@ Do not check the same pointer for @code{NULL} more than once. @item Use long function and variable names in English; This makes your code easier to read. Use the 'varible_name' style instead of 'VariableName'. easier to read. @item Use my_var as opposed to myVar or MyVar (@samp{_} rather than dancing SHIFT to seperate words in identifiers). @item Think assembly - make it easier for the compiler to optimize your code. Loading @@ -232,14 +240,8 @@ Comment your code when you do something that someone else may think is not ''trivial''. @item Use the @code{my_*} functions like @code{my_read()}/@code{my_write()}/ @code{my_malloc()} that you can find in the @code{mysys} library instead of the direct system calls; This will make your code easier to debug and more portable. @item Use @code{libstring} functions instead of standard libc string functions whenever possible. Use @code{libstring} functions (in the strings directory) instead of standard libc string functions whenever possible. @item Avoid using @code{malloc()} (its REAL slow); For memory allocations Loading @@ -253,10 +255,6 @@ it. This way we can easily provide you with feedback and also easily discuss it thoroughly if some other developer thinks there is better way to do the same thing! @item Use my_var as opposed to myVar or MyVar (@samp{_} rather than dancing SHIFT to seperate words in identifiers). @item Class names start with a capital letter. Loading configure.in +1 −1 Original line number Diff line number Diff line Loading @@ -1769,7 +1769,7 @@ then fi AC_SUBST(tools_dirs) MYSQL_CHECK_CPU #MYSQL_CHECK_CPU MYSQL_CHECK_MYSQLFS MYSQL_CHECK_VIO MYSQL_CHECK_OPENSSL Loading include/mysql.h +5 −5 Original line number Diff line number Diff line Loading @@ -253,15 +253,15 @@ typedef struct st_mysql_manager /* Set up and bring down the server; to ensure that applications will * work when linked against either the standard client library or the * embedded server library, these functions should be called. */ int mysql_server_init(int argc, char **argv, char **groups); void mysql_server_end(void); int STDCALL mysql_server_init(int argc, char **argv, char **groups); void STDCALL mysql_server_end(void); /* Set up and bring down a thread; these function should be called * for each thread in an application which opens at least one MySQL * connection. All uses of the connection(s) should be between these * function calls. */ my_bool mysql_thread_init(void); void mysql_thread_end(void); my_bool STDCALL mysql_thread_init(void); void STDCALL mysql_thread_end(void); /* Functions to get information from the MYSQL and MYSQL_RES structures */ /* Should definitely be used if one uses shared libraries */ Loading Loading @@ -414,8 +414,8 @@ MYSQL * STDCALL mysql_connect(MYSQL *mysql, const char *host, int STDCALL mysql_create_db(MYSQL *mysql, const char *DB); int STDCALL mysql_drop_db(MYSQL *mysql, const char *DB); #define mysql_reload(mysql) mysql_refresh((mysql),REFRESH_GRANT) #define HAVE_MYSQL_REAL_CONNECT #endif #define HAVE_MYSQL_REAL_CONNECT /* The following functions are mainly exported because of mysqlbinlog; Loading include/mysqld_error.h +13 −10 Original line number Diff line number Diff line Loading @@ -214,13 +214,16 @@ #define ER_NO_PERMISSION_TO_CREATE_USER 1211 #define ER_UNION_TABLES_IN_DIFFERENT_DIR 1212 #define ER_LOCK_DEADLOCK 1213 #define ER_CONNECT_TO_MASTER 1214 #define ER_QUERY_ON_MASTER 1215 #define ER_ERROR_WHEN_EXECUTING_COMMAND 1216 #define ER_WRONG_USAGE 1217 #define ER_WRONG_NUMBER_OF_COLUMNS_IN_SELECT 1218 #define ER_CANT_UPDATE_WITH_READLOCK 1219 #define ER_MIXING_NOT_ALLOWED 1220 #define ER_DUP_ARGUMENT 1221 #define ER_TABLE_CANT_HANDLE_FULLTEXT 1222 #define ER_ERROR_MESSAGES 223 #define ER_TABLE_CANT_HANDLE_FULLTEXT 1214 #define ER_CANNOT_ADD_FOREIGN 1215 #define ER_NO_REFERENCED_ROW 1216 #define ER_ROW_IS_REFERENCED 1217 #define ER_CONNECT_TO_MASTER 1218 #define ER_QUERY_ON_MASTER 1219 #define ER_ERROR_WHEN_EXECUTING_COMMAND 1220 #define ER_WRONG_USAGE 1221 #define ER_WRONG_NUMBER_OF_COLUMNS_IN_SELECT 1222 #define ER_CANT_UPDATE_WITH_READLOCK 1223 #define ER_MIXING_NOT_ALLOWED 1224 #define ER_DUP_ARGUMENT 1225 #define ER_ERROR_MESSAGES 226 Loading
BitKeeper/etc/logging_ok +5 −4 Original line number Diff line number Diff line Administrator@co3064164-a. Administrator@co3064164-a.rochd1.qld.optushome.com.au Administrator@fred. Miguel@light.local Sinisa@sinisa.nasamreza.org ahlentz@co3064164-a.rochd1.qld.optusnet.com.au arjen@co3064164-a.bitbike.com davida@isil.mysql.com heikki@donna.mysql.fi jani@hynda.mysql.fi Loading @@ -13,6 +17,7 @@ monty@bitch.mysql.fi monty@donna.mysql.fi monty@hundin.mysql.fi monty@tik.mysql.fi monty@tramp.mysql.fi monty@work.mysql.com mwagner@evoq.mwagner.org paul@central.snake.net Loading @@ -31,7 +36,3 @@ tonu@hundin.mysql.fi tonu@volk.internalnet tonu@x153.internalnet tonu@x3.internalnet Administrator@co3064164-a. Administrator@co3064164-a.rochd1.qld.optushome.com.au ahlentz@co3064164-a.rochd1.qld.optusnet.com.au arjen@co3064164-a.bitbike.com
Docs/internals.texi +18 −20 Original line number Diff line number Diff line Loading @@ -183,23 +183,27 @@ and then we read the rows in the sorted order into a row buffer We are using @uref{http://www.bitkeeper.com/, BitKeeper} for source management. @item You should use the @strong{MySQL} 3.23 or 4.0 source for all developments. You should use the @strong{MySQL} 4.0 source for all developments. @item If you have any questions about the @strong{MySQL} source, you can post these to @email{developers@@mysql.com} and we will answer them. Note that we will shortly change the name of this list to @email{internals@@mysql.com}, to more accurately reflect what should be posted to this list. to @email{dev-public@@mysql.com} and we will answer them. Please remember to not use this internal email list in public! @item Try to write code in a lot of black boxes that can be reused or at least have a clean interface. Try to write code in a lot of black boxes that can be reused or use at least a clean, easy to change interface. @item Reuse code; There is already a lot of algorithms in MySQL for list handling, queues, dynamic and hashed arrays, sorting, etc. that can be reused. @item Use the @code{my_*} functions like @code{my_read()}/@code{my_write()}/ @code{my_malloc()} that you can find in the @code{mysys} library instead of the direct system calls; This will make your code easier to debug and more portable. @item Try to always write optimized code, so that you don't have to go back and rewrite it a couple of months later. It's better to Loading @@ -222,7 +226,11 @@ Do not check the same pointer for @code{NULL} more than once. @item Use long function and variable names in English; This makes your code easier to read. Use the 'varible_name' style instead of 'VariableName'. easier to read. @item Use my_var as opposed to myVar or MyVar (@samp{_} rather than dancing SHIFT to seperate words in identifiers). @item Think assembly - make it easier for the compiler to optimize your code. Loading @@ -232,14 +240,8 @@ Comment your code when you do something that someone else may think is not ''trivial''. @item Use the @code{my_*} functions like @code{my_read()}/@code{my_write()}/ @code{my_malloc()} that you can find in the @code{mysys} library instead of the direct system calls; This will make your code easier to debug and more portable. @item Use @code{libstring} functions instead of standard libc string functions whenever possible. Use @code{libstring} functions (in the strings directory) instead of standard libc string functions whenever possible. @item Avoid using @code{malloc()} (its REAL slow); For memory allocations Loading @@ -253,10 +255,6 @@ it. This way we can easily provide you with feedback and also easily discuss it thoroughly if some other developer thinks there is better way to do the same thing! @item Use my_var as opposed to myVar or MyVar (@samp{_} rather than dancing SHIFT to seperate words in identifiers). @item Class names start with a capital letter. Loading
configure.in +1 −1 Original line number Diff line number Diff line Loading @@ -1769,7 +1769,7 @@ then fi AC_SUBST(tools_dirs) MYSQL_CHECK_CPU #MYSQL_CHECK_CPU MYSQL_CHECK_MYSQLFS MYSQL_CHECK_VIO MYSQL_CHECK_OPENSSL Loading
include/mysql.h +5 −5 Original line number Diff line number Diff line Loading @@ -253,15 +253,15 @@ typedef struct st_mysql_manager /* Set up and bring down the server; to ensure that applications will * work when linked against either the standard client library or the * embedded server library, these functions should be called. */ int mysql_server_init(int argc, char **argv, char **groups); void mysql_server_end(void); int STDCALL mysql_server_init(int argc, char **argv, char **groups); void STDCALL mysql_server_end(void); /* Set up and bring down a thread; these function should be called * for each thread in an application which opens at least one MySQL * connection. All uses of the connection(s) should be between these * function calls. */ my_bool mysql_thread_init(void); void mysql_thread_end(void); my_bool STDCALL mysql_thread_init(void); void STDCALL mysql_thread_end(void); /* Functions to get information from the MYSQL and MYSQL_RES structures */ /* Should definitely be used if one uses shared libraries */ Loading Loading @@ -414,8 +414,8 @@ MYSQL * STDCALL mysql_connect(MYSQL *mysql, const char *host, int STDCALL mysql_create_db(MYSQL *mysql, const char *DB); int STDCALL mysql_drop_db(MYSQL *mysql, const char *DB); #define mysql_reload(mysql) mysql_refresh((mysql),REFRESH_GRANT) #define HAVE_MYSQL_REAL_CONNECT #endif #define HAVE_MYSQL_REAL_CONNECT /* The following functions are mainly exported because of mysqlbinlog; Loading
include/mysqld_error.h +13 −10 Original line number Diff line number Diff line Loading @@ -214,13 +214,16 @@ #define ER_NO_PERMISSION_TO_CREATE_USER 1211 #define ER_UNION_TABLES_IN_DIFFERENT_DIR 1212 #define ER_LOCK_DEADLOCK 1213 #define ER_CONNECT_TO_MASTER 1214 #define ER_QUERY_ON_MASTER 1215 #define ER_ERROR_WHEN_EXECUTING_COMMAND 1216 #define ER_WRONG_USAGE 1217 #define ER_WRONG_NUMBER_OF_COLUMNS_IN_SELECT 1218 #define ER_CANT_UPDATE_WITH_READLOCK 1219 #define ER_MIXING_NOT_ALLOWED 1220 #define ER_DUP_ARGUMENT 1221 #define ER_TABLE_CANT_HANDLE_FULLTEXT 1222 #define ER_ERROR_MESSAGES 223 #define ER_TABLE_CANT_HANDLE_FULLTEXT 1214 #define ER_CANNOT_ADD_FOREIGN 1215 #define ER_NO_REFERENCED_ROW 1216 #define ER_ROW_IS_REFERENCED 1217 #define ER_CONNECT_TO_MASTER 1218 #define ER_QUERY_ON_MASTER 1219 #define ER_ERROR_WHEN_EXECUTING_COMMAND 1220 #define ER_WRONG_USAGE 1221 #define ER_WRONG_NUMBER_OF_COLUMNS_IN_SELECT 1222 #define ER_CANT_UPDATE_WITH_READLOCK 1223 #define ER_MIXING_NOT_ALLOWED 1224 #define ER_DUP_ARGUMENT 1225 #define ER_ERROR_MESSAGES 226