Commit 2e480773 authored by unknown's avatar unknown
Browse files

Change 'Build-tools/Do-compile' from 'system("rm -f ...");' to 'unlink()' to ensure 

it also works on file names with special characters.


Build-tools/Do-compile:
  Ever and again, some test creates a file name with special characters that need to be
  escaped when passed to the shell; as this is not done, 'system("rm -f ...");' fails
  on them, the old test tree is not deleted, and the build fails.
  Prevent this by changing to Perl 'unlink()' which does not need escaping.
parent 1b17ba52

Build-tools/Do-compile

+4 −2
Original line number Diff line number Diff line
@@ -729,7 +729,7 @@ sub find 
sub rm_all

{

  my(@rm_files)=@_;

  my($dir,$current_dir,@files,@dirs);

  my($dir,$current_dir,@files,@dirs,$removed);

  $current_dir = `pwd`; chomp($current_dir);



  foreach $dir (@rm_files)
@@ -753,7 +753,9 @@ sub rm_all 
      }

      if ($#files >= 0)

      {

	system("rm -f " . join(" ",@files)) && abort("Can't remove files from $dir");

	$removed= unlink @files;

	print "rm_all : removed $removed files in $current_dir/$dir\n" if ($opt_debug);

	abort("Can't remove all $#files+1 from $current_dir/$dir, just $removed") if $removed != $#files+1;

      }

      foreach $dir (@dirs)

      {