Commit 2ec2fa6d authored by unknown's avatar unknown
Browse files

Cleanup of thread-type (linuxthread or NTPL) detection code 

Move get_thread_lib to mysys/my_pthread.c
Set 'thr_client_alarm' to signal number used by thr_alarm to give alarms



include/my_global.h:
  Fixed to be same as in 5.1
include/my_pthread.h:
  Move things around to be more in line with rest of code
include/thr_alarm.h:
  extern of thr_client_alarm
mysys/default.c:
  Fixed two wrong pointer incrementations.
mysys/my_pthread.c:
  Cleanup: Use variable thr_client_alarm
mysys/my_thr_init.c:
  Detect thread library at startup
mysys/thr_alarm.c:
  Set thr_client_alarm depending on which thread library we are using
sql/mysqld.cc:
  Move get_thread_lib to mysys/my_pthread.c
parent 454c763c

include/my_global.h

+1 −4
Original line number Diff line number Diff line
@@ -348,10 +348,7 @@ int __void__; 
#endif



/* Define some useful general macros */

#if defined(__cplusplus) && defined(__GNUC__)

#define max(a, b)     ((a) >? (b))

#define min(a, b)     ((a) <? (b))

#elif !defined(max)

#if !defined(max)

#define max(a, b)	((a) > (b) ? (a) : (b))

#define min(a, b)	((a) < (b) ? (a) : (b))

#endif

include/my_pthread.h

+8 −8
Original line number Diff line number Diff line
@@ -28,14 +28,6 @@ 
extern "C" {

#endif /* __cplusplus */ 



/* Thread library */



#define THD_LIB_OTHER 1

#define THD_LIB_NPTL  2

#define THD_LIB_LT    4



extern uint thd_lib_detected;



#if defined(__WIN__) || defined(OS2)



#ifdef OS2
@@ -684,6 +676,14 @@ extern struct st_my_thread_var *_my_thread_var(void) __attribute__ ((const)); 
*/

extern pthread_t shutdown_th, main_th, signal_th;



/* Which kind of thread library is in use */



#define THD_LIB_OTHER 1

#define THD_LIB_NPTL  2

#define THD_LIB_LT    4



extern uint thd_lib_detected;



	/* statistics_xxx functions are for not essential statistic */



#ifndef thread_safe_increment

include/thr_alarm.h

+2 −0
Original line number Diff line number Diff line
@@ -93,6 +93,8 @@ typedef struct st_alarm { 
  my_bool malloced;

} ALARM;



extern uint thr_client_alarm;



#define thr_alarm_init(A) (*(A))=0

#define thr_alarm_in_use(A) (*(A)!= 0)

void init_thr_alarm(uint max_alarm);

mysys/default.c

+2 −2
Original line number Diff line number Diff line
@@ -282,7 +282,7 @@ static int search_default_file(DYNAMIC_ARRAY *args, MEM_ROOT *alloc, 
{

  char **ext;



  for (ext= (char**) f_extensions; *ext; *ext++)

  for (ext= (char**) f_extensions; *ext; ext++)

  {

    int error;

    if ((error= search_default_file_with_ext(args, alloc, dir, *ext,
@@ -543,7 +543,7 @@ void print_defaults(const char *conf_file, const char **groups) 
#endif

    for (dirs=default_directories ; *dirs; dirs++)

    {

      for (ext= (char**) f_extensions; *ext; *ext++)

      for (ext= (char**) f_extensions; *ext; ext++)

      {

	const char *pos;

	char *end;

mysys/my_pthread.c

+3 −1
Original line number Diff line number Diff line
@@ -322,7 +322,9 @@ void *sigwait_thread(void *set_arg) 
      sigaction(i, &sact, (struct sigaction*) 0);

    }

  }

  sigaddset(set, thd_lib_detected == THD_LIB_LT ? SIGALRM : SIGUSR1);

  /* Ensure that init_thr_alarm() is called */

  DBUG_ASSERT(thr_client_alarm);

  sigaddset(set, thr_client_alarm);

  pthread_sigmask(SIG_UNBLOCK,(sigset_t*) set,(sigset_t*) 0);

  alarm_thread=pthread_self();			/* For thr_alarm */