Commit 33294b1b authored by unknown's avatar unknown
Browse files

Preliminary patch for the following bugs: 

  - BUG#15934: Instance manager fails to work;
  - BUG#18020: IM connect problem;
  - BUG#18027: IM: Server_ID differs;
  - BUG#18033: IM: Server_ID not reported;
  - BUG#21331: Instance Manager: Connect problems in tests;

The only test suite has been changed
(server codebase has not been modified).


BitKeeper/deleted/.del-im_check_os.inc:
  Rename: mysql-test/include/im_check_os.inc -> BitKeeper/deleted/.del-im_check_os.inc
mysql-test/include/im_check_env.inc:
  Include only this file from all IM-tests.
mysql-test/lib/mtr_io.pl:
  Update mtr_get_pid_from_file() to workaround race,
  described in BUG#21884.
mysql-test/lib/mtr_process.pl:
  Refactor im_start()/im_stop() so that they will be more
  reliable. There are the following user-visible changes:
    - if one of these functions fails, the test suite
      is aborted;
    - mtr_im_stop() now determines whether the component is
      alive or not not only by checking PID, but also by trying
      to connect to the component;
    - after starting IM, the test suite waits for it to start
      accepting client connections and to start all its guarded
      mysqld instances;
    - a lot of debug-logs have been added in order to simplify
      investigation of future failures.
mysql-test/mysql-test-run.pl:
  1. Get rid of kill_and_cleanup();
  2. Move im_start()/im_stop() to mtr_process.pl;
  3. Change default IM port to 9311 so that it does not interfere
     with default slave port;
mysql-test/r/im_daemon_life_cycle.result:
  Updated result file.
mysql-test/r/im_life_cycle.result:
  Updated result file.
mysql-test/r/im_options_set.result:
  Updated result file.
mysql-test/r/im_options_unset.result:
  Updated result file.
mysql-test/r/im_utils.result:
  Updated result file.
mysql-test/t/im_daemon_life_cycle.imtest:
  Updated IM-test.
mysql-test/t/im_life_cycle.imtest:
  Updated IM-test.
mysql-test/t/im_options_set.imtest:
  Updated IM-test.
mysql-test/t/im_options_unset.imtest:
  Updated IM-test.
mysql-test/t/im_utils.imtest:
  Updated IM-test.
parent 3cd6015c

BitKeeper/etc/collapsed

+1 −0
Original line number Diff line number Diff line 
44d03f27qNdqJmARzBoP3Is_cN5e0w

44ec850ac2k4y2Omgr92GiWPBAVKGQ

44edb86b1iE5knJ97MbliK_3lCiAXA

44f33f3aj5KW5qweQeekY1LU0E9ZCg

mysql-test/include/im_check_env.inc

+2 −4
Original line number Diff line number Diff line
@@ -2,10 +2,6 @@ 
# that ensure that starting conditions (environment) for the IM-test are as

# expected.



# Wait for mysqld1 (guarded instance) to start.



--exec $MYSQL_TEST_DIR/t/wait_for_process.sh $IM_MYSQLD1_PATH_PID 30 started



# Check the running instances.



--connect (mysql1_con,localhost,root,,mysql,$IM_MYSQLD1_PORT,$IM_MYSQLD1_SOCK)
@@ -14,6 +10,8 @@ 


SHOW VARIABLES LIKE 'server_id';



--source include/not_windows.inc



--connection default



# Let IM detect that mysqld1 is online. This delay should be longer than

mysql-test/include/im_check_os.inc

deleted100644 → 0
+0 −7
Original line number Diff line number Diff line 
--connect (dflt_server_con,localhost,root,,mysql,$IM_MYSQLD1_PORT,$IM_MYSQLD1_SOCK)

--connection dflt_server_con



--source include/not_windows.inc



--connection default

--disconnect dflt_server_con

mysql-test/lib/mtr_io.pl

+32 −6
Original line number Diff line number Diff line
@@ -19,13 +19,39 @@ sub mtr_tonewfile($@); 
##############################################################################



sub mtr_get_pid_from_file ($) {

  my $file=  shift;

  my $pid_file_path=  shift;

  my $TOTAL_ATTEMPTS= 30;

  my $timeout= 1;



  # We should read from the file until we get correct pid. As it is

  # stated in BUG#21884, pid file can be empty at some moment. So, we should

  # read it until we get valid data.



  for (my $cur_attempt= 1; $cur_attempt <= $TOTAL_ATTEMPTS; ++$cur_attempt)

  {

    mtr_debug("Reading pid file '$pid_file_path' " .

              "($cur_attempt of $TOTAL_ATTEMPTS)...");



    open(FILE, '<', $pid_file_path)

      or mtr_error("can't open file \"$pid_file_path\": $!");



  open(FILE,"<",$file) or mtr_error("can't open file \"$file\": $!");

    my $pid= <FILE>;

  chomp($pid);



    chomp($pid) if defined $pid;



    close FILE;

  return $pid;



    return $pid if defined $pid && $pid ne '';



    mtr_debug("Pid file '$pid_file_path' is empty. " .

              "Sleeping $timeout second(s)...");



    sleep(1);

  }



  mtr_error("Pid file '$pid_file_path' is corrupted. " .

            "Can not retrieve PID in " .

            ($timeout * $TOTAL_ATTEMPTS) . " seconds.");

}



sub mtr_get_opts_from_file ($) {

mysql-test/lib/mtr_process.pl

+782 −54

File changed.

Preview size limit exceeded, changes collapsed.