Commit 3798a7d5 authored by unknown's avatar unknown
Browse files

sql_insert.cc: 

  Removed wrong fix for the bug#27006.
  The bug was added by the fix for the bug#19978 and fixed by Monty on 2007/02/21.
trigger.test, trigger.result:
  Corrected test case for the bug#27006.


sql/sql_insert.cc:
  Removed wrong fix for the bug#27006.
  The bug was added by the fix for the bug#19978 and fixed by Monty on 2007/02/21.
mysql-test/t/trigger.test:
  Corrected test case for the bug#27006.
mysql-test/r/trigger.result:
  Corrected test case for the bug#27006.
parent 6d93f150

mysql-test/r/trigger.result

+6 −5
Original line number Diff line number Diff line
@@ -1398,18 +1398,19 @@ id val 
1	test1

2	test2

INSERT INTO t1 VALUES (2,'test2') ON DUPLICATE KEY UPDATE val=VALUES(val);

INSERT INTO t1 VALUES (3,'test3') ON DUPLICATE KEY UPDATE val=VALUES(val);

INSERT INTO t1 VALUES (2,'test3') ON DUPLICATE KEY UPDATE val=VALUES(val);

INSERT INTO t1 VALUES (3,'test4') ON DUPLICATE KEY UPDATE val=VALUES(val);

SELECT * FROM t1;

id	val

1	test1

2	test2

3	test3

2	test3

3	test4

SELECT * FROM t2;

id	val

1	test1

2	test2

3	test2

4	test3

3	test3

4	test4

DROP TRIGGER trg27006_a_insert;

DROP TRIGGER trg27006_a_update;

drop table t1,t2;

mysql-test/t/trigger.test

+3 −3
Original line number Diff line number Diff line
@@ -1700,8 +1700,7 @@ DROP PROCEDURE bug22580_proc_1; 
DROP PROCEDURE bug22580_proc_2;



#

# Bug#27006: AFTER UPDATE triggers not fired with INSERT ... ON DUPLICATE KEY

#            UPDATE if the row wasn't actually changed.

# Bug#27006: AFTER UPDATE triggers not fired with INSERT ... ON DUPLICATE

#

--disable_warnings

DROP TRIGGER IF EXISTS trg27006_a_update;
@@ -1730,7 +1729,8 @@ INSERT INTO t1(val) VALUES ('test1'),('test2'); 
SELECT * FROM t1;

SELECT * FROM t2;

INSERT INTO t1 VALUES (2,'test2') ON DUPLICATE KEY UPDATE val=VALUES(val);

INSERT INTO t1 VALUES (3,'test3') ON DUPLICATE KEY UPDATE val=VALUES(val);

INSERT INTO t1 VALUES (2,'test3') ON DUPLICATE KEY UPDATE val=VALUES(val);

INSERT INTO t1 VALUES (3,'test4') ON DUPLICATE KEY UPDATE val=VALUES(val);

SELECT * FROM t1;

SELECT * FROM t2;

DROP TRIGGER trg27006_a_insert;

sql/sql_insert.cc

+5 −5
Original line number Diff line number Diff line
@@ -1238,19 +1238,19 @@ int write_record(THD *thd, TABLE *table,COPY_INFO *info) 
        if (table->next_number_field)

          table->file->adjust_next_insert_id_after_explicit_value(

            table->next_number_field->val_int());



        info->touched++;



        if ((table->file->table_flags() & HA_PARTIAL_COLUMN_READ) ||

            compare_record(table, thd->query_id))

        {

          info->updated++;

          info->copied++;

        }



          trg_error= (table->triggers &&

                      table->triggers->process_triggers(thd, TRG_EVENT_UPDATE,

                                                        TRG_ACTION_AFTER,

                                                        TRUE));

          info->copied++;

        }



        goto ok_or_after_trg_err;

      }

      else /* DUP_REPLACE */