Commit 3ecf9f04 authored by unknown's avatar unknown
Browse files

Fix for bug#14385 GRANT and mapping to correct user account problems 

  Check if the host of table hash record exactly matches host from GRANT command


mysql-test/r/grant.result:
  Fix for bug#14385 GRANT and mapping to correct user account problems
    test case
mysql-test/t/grant.test:
  Fix for bug#14385 GRANT and mapping to correct user account problems
    test case
parent 4391f938

mysql-test/r/grant.result

+18 −0
Original line number Diff line number Diff line
@@ -473,3 +473,21 @@ GRANT USAGE ON *.* TO 'mysqltest_7'@'' IDENTIFIED BY PASSWORD '*2FB071A056F9BB74 
drop user mysqltest_7@;

show grants for mysqltest_7@;

ERROR 42000: There is no such grant defined for user 'mysqltest_7' on host ''

create database mysqltest;

use mysqltest;

create table t1(f1 int);

GRANT DELETE ON mysqltest.t1 TO mysqltest1@'%';

GRANT SELECT ON mysqltest.t1 TO mysqltest1@'192.%';

show grants for mysqltest1@'192.%';

Grants for mysqltest1@192.%

GRANT USAGE ON *.* TO 'mysqltest1'@'192.%'

GRANT SELECT ON `mysqltest`.`t1` TO 'mysqltest1'@'192.%'

show grants for mysqltest1@'%';

Grants for mysqltest1@%

GRANT USAGE ON *.* TO 'mysqltest1'@'%'

GRANT DELETE ON `mysqltest`.`t1` TO 'mysqltest1'@'%'

delete from mysql.user where user='mysqltest1';

delete from mysql.db where user='mysqltest1';

delete from mysql.tables_priv where user='mysqltest1';

flush privileges;

drop database mysqltest;

mysql-test/t/grant.test

+16 −0
Original line number Diff line number Diff line
@@ -433,4 +433,20 @@ drop user mysqltest_7@; 
--error 1141

show grants for mysqltest_7@;



#

# Bug#14385: GRANT and mapping to correct user account problems

#

create database mysqltest;

use mysqltest;

create table t1(f1 int);

GRANT DELETE ON mysqltest.t1 TO mysqltest1@'%';

GRANT SELECT ON mysqltest.t1 TO mysqltest1@'192.%';

show grants for mysqltest1@'192.%';

show grants for mysqltest1@'%';

delete from mysql.user where user='mysqltest1';

delete from mysql.db where user='mysqltest1';

delete from mysql.tables_priv where user='mysqltest1';

flush privileges;

drop database mysqltest;



# End of 4.1 tests

sql/sql_acl.cc

+4 −1
Original line number Diff line number Diff line
@@ -2001,7 +2001,10 @@ static GRANT_TABLE *table_hash_search(const char *host,const char* ip, 
  {

    if (exact)

    {

      if (compare_hostname(&grant_table->host, host, ip))

      if ((host &&

	   !my_strcasecmp(system_charset_info, host,

                          grant_table->host.hostname)) ||

	  (ip && !strcmp(ip, grant_table->host.hostname)))

	return grant_table;

    }

    else