Commit 489ad44a authored by Georgi Kodinov's avatar Georgi Kodinov
Browse files

Bug #32124: crash if prepared statements refer to variables in the where clause 

                  
The code to get read the value of a system variable was extracting its value 
on PREPARE stage and was substituting the value (as a constant) into the parse tree.
Note that this must be a reversible transformation, i.e. it must be reversed before
each re-execution.
Unfortunately this cannot be reliably done using the current code, because there are
other non-reversible source tree transformations that can interfere with this
reversible transformation.
Fixed by not resolving the value at PREPARE, but at EXECUTE (as the rest of the 
functions operate). Added a cache of the value (so that it's constant throughout
the execution of the query). Note that the cache also caches NULL values.
Updated an obsolete related test suite (variables-big) and the code to test the 
result type of system variables (as per bug 74).
parent 7fa30b28

mysql-test/extra/rpl_tests/rpl_insert_id.test

+0 −2
Original line number Diff line number Diff line
@@ -442,8 +442,6 @@ SELECT f1(); 
INSERT INTO t1 VALUES (NULL, f2()), (NULL, LAST_INSERT_ID()),

                      (NULL, LAST_INSERT_ID()), (NULL, f2()), (NULL, f2());

INSERT INTO t1 VALUES (NULL, f2());

INSERT INTO t1 VALUES (NULL, LAST_INSERT_ID()), (NULL, LAST_INSERT_ID(5)),

                      (NULL, @@LAST_INSERT_ID);

# Test replication of substitution "IS NULL" -> "= LAST_INSERT_ID".

INSERT INTO t1 VALUES (NULL, 0), (NULL, LAST_INSERT_ID());

UPDATE t1 SET j= -1 WHERE i IS NULL;

mysql-test/r/innodb_data_home_dir_basic.result

+5 −5
Original line number Diff line number Diff line 
'#---------------------BS_STVARS_025_01----------------------#'

SELECT COUNT(@@GLOBAL.innodb_data_home_dir);

COUNT(@@GLOBAL.innodb_data_home_dir)

0

1

1 Expected

'#---------------------BS_STVARS_025_02----------------------#'

SET @@GLOBAL.innodb_data_home_dir=1;
@@ -9,7 +9,7 @@ ERROR HY000: Variable 'innodb_data_home_dir' is a read only variable 
Expected error 'Read only variable'

SELECT COUNT(@@GLOBAL.innodb_data_home_dir);

COUNT(@@GLOBAL.innodb_data_home_dir)

0

1

1 Expected

'#---------------------BS_STVARS_025_03----------------------#'

SELECT @@GLOBAL.innodb_data_home_dir = VARIABLE_VALUE
@@ -20,7 +20,7 @@ NULL 
1 Expected

SELECT COUNT(@@GLOBAL.innodb_data_home_dir);

COUNT(@@GLOBAL.innodb_data_home_dir)

0

1

1 Expected

SELECT COUNT(VARIABLE_VALUE)

FROM INFORMATION_SCHEMA.GLOBAL_VARIABLES
@@ -36,7 +36,7 @@ NULL 
'#---------------------BS_STVARS_025_05----------------------#'

SELECT COUNT(@@innodb_data_home_dir);

COUNT(@@innodb_data_home_dir)

0

1

1 Expected

SELECT COUNT(@@local.innodb_data_home_dir);

ERROR HY000: Variable 'innodb_data_home_dir' is a GLOBAL variable
@@ -46,7 +46,7 @@ ERROR HY000: Variable 'innodb_data_home_dir' is a GLOBAL variable 
Expected error 'Variable is a GLOBAL variable'

SELECT COUNT(@@GLOBAL.innodb_data_home_dir);

COUNT(@@GLOBAL.innodb_data_home_dir)

0

1

1 Expected

SELECT innodb_data_home_dir = @@SESSION.innodb_data_home_dir;

ERROR 42S22: Unknown column 'innodb_data_home_dir' in 'field list'

mysql-test/r/innodb_flush_method_basic.result

+5 −5
Original line number Diff line number Diff line 
'#---------------------BS_STVARS_029_01----------------------#'

SELECT COUNT(@@GLOBAL.innodb_flush_method);

COUNT(@@GLOBAL.innodb_flush_method)

0

1

1 Expected

'#---------------------BS_STVARS_029_02----------------------#'

SET @@GLOBAL.innodb_flush_method=1;
@@ -9,7 +9,7 @@ ERROR HY000: Variable 'innodb_flush_method' is a read only variable 
Expected error 'Read only variable'

SELECT COUNT(@@GLOBAL.innodb_flush_method);

COUNT(@@GLOBAL.innodb_flush_method)

0

1

1 Expected

'#---------------------BS_STVARS_029_03----------------------#'

SELECT @@GLOBAL.innodb_flush_method = VARIABLE_VALUE
@@ -20,7 +20,7 @@ NULL 
1 Expected

SELECT COUNT(@@GLOBAL.innodb_flush_method);

COUNT(@@GLOBAL.innodb_flush_method)

0

1

1 Expected

SELECT COUNT(VARIABLE_VALUE)

FROM INFORMATION_SCHEMA.GLOBAL_VARIABLES
@@ -36,7 +36,7 @@ NULL 
'#---------------------BS_STVARS_029_05----------------------#'

SELECT COUNT(@@innodb_flush_method);

COUNT(@@innodb_flush_method)

0

1

1 Expected

SELECT COUNT(@@local.innodb_flush_method);

ERROR HY000: Variable 'innodb_flush_method' is a GLOBAL variable
@@ -46,7 +46,7 @@ ERROR HY000: Variable 'innodb_flush_method' is a GLOBAL variable 
Expected error 'Variable is a GLOBAL variable'

SELECT COUNT(@@GLOBAL.innodb_flush_method);

COUNT(@@GLOBAL.innodb_flush_method)

0

1

1 Expected

SELECT innodb_flush_method = @@SESSION.innodb_flush_method;

ERROR 42S22: Unknown column 'innodb_flush_method' in 'field list'

mysql-test/r/ps_11bugs.result

+28 −0
Original line number Diff line number Diff line
@@ -162,4 +162,32 @@ a b 
12	NULL

drop table t1;

drop table t2;

CREATE TABLE t1 (a INT);

PREPARE stmt FROM 'select 1 from `t1` where `a` = any (select (@@tmpdir))';

EXECUTE stmt;

1

DEALLOCATE PREPARE stmt;

DROP TABLE t1;

CREATE TABLE t2 (a INT PRIMARY KEY);

INSERT INTO t2 VALUES (400000), (400001);

SET @@sort_buffer_size=400000;

CREATE FUNCTION p1(i INT) RETURNS INT

BEGIN

SET @@sort_buffer_size= i;

RETURN i + 1;

END|

SELECT * FROM t2 WHERE a = @@sort_buffer_size AND p1(@@sort_buffer_size + 1) > a - 1;

a

400000

DROP TABLE t2;

DROP FUNCTION p1;

SELECT CONCAT(@@sort_buffer_size);

CONCAT(@@sort_buffer_size)

400001

SELECT LEFT("12345", @@ft_boolean_syntax);

LEFT("12345", @@ft_boolean_syntax)



Warnings:

Warning	1292	Truncated incorrect INTEGER value: '+ -><()~*:""&|'

SET @@sort_buffer_size=DEFAULT;

End of 5.0 tests.

mysql-test/r/ssl_capath_basic.result

+5 −5
Original line number Diff line number Diff line 
'#---------------------BS_STVARS_046_01----------------------#'

SELECT COUNT(@@GLOBAL.ssl_capath);

COUNT(@@GLOBAL.ssl_capath)

0

1

1 Expected

'#---------------------BS_STVARS_046_02----------------------#'

SET @@GLOBAL.ssl_capath=1;
@@ -9,7 +9,7 @@ ERROR HY000: Variable 'ssl_capath' is a read only variable 
Expected error 'Read only variable'

SELECT COUNT(@@GLOBAL.ssl_capath);

COUNT(@@GLOBAL.ssl_capath)

0

1

1 Expected

'#---------------------BS_STVARS_046_03----------------------#'

SELECT @@GLOBAL.ssl_capath = VARIABLE_VALUE
@@ -20,7 +20,7 @@ NULL 
1 Expected

SELECT COUNT(@@GLOBAL.ssl_capath);

COUNT(@@GLOBAL.ssl_capath)

0

1

1 Expected

SELECT COUNT(VARIABLE_VALUE)

FROM INFORMATION_SCHEMA.GLOBAL_VARIABLES
@@ -36,7 +36,7 @@ NULL 
'#---------------------BS_STVARS_046_05----------------------#'

SELECT COUNT(@@ssl_capath);

COUNT(@@ssl_capath)

0

1

1 Expected

SELECT COUNT(@@local.ssl_capath);

ERROR HY000: Variable 'ssl_capath' is a GLOBAL variable
@@ -46,7 +46,7 @@ ERROR HY000: Variable 'ssl_capath' is a GLOBAL variable 
Expected error 'Variable is a GLOBAL variable'

SELECT COUNT(@@GLOBAL.ssl_capath);

COUNT(@@GLOBAL.ssl_capath)

0

1

1 Expected

SELECT ssl_capath = @@SESSION.ssl_capath;

ERROR 42S22: Unknown column 'ssl_capath' in 'field list'