Commit 59a33015 authored by unknown's avatar unknown
Browse files

Fixed Bug#19479:mysqldump creates invalid dump. 

Only check for FN_DEVCHAR in filenames if FN_DEVCHAR is defined.
This allows to use table names with ":" on non windows platforms.
On Windows platform get an error if you use table name that contains FN_DEVCHAR


include/config-win.h:
  Moved FN_DEVCHAR to config-win.h
include/my_global.h:
  Moved FN_DEVCHAR to config-win.h
mysql-test/r/create.result:
  Added testcase for Bug#19479:mysqldump creates invalid dump
BitKeeper/etc/ignore:
  Added sql/share/iso639-2.txt sql/share/fixerrmsg.pl to the ignore list
mysql-test/t/create.test:
  Added testcase for Bug#19479:mysqldump creates invalid dump
mysys/mf_fn_ext.c:
  Added checking of BASKSLASH_MBTAIL as dirname_part depends on it.
  Fixed cast and indentation.
sql/table.cc:
  Only check for FN_DEVCHAR in filenames if FN_DEVCHAR is defined.
  This allows to use table names with ":" on non windows platforms.
  On Windows platform get an error if you use table name that contains FN_DEVCHAR
parent 58808271

.bzrignore

+2 −0
Original line number Diff line number Diff line
@@ -1282,3 +1282,5 @@ extra/yassl/taocrypt/benchmark/benchmark 
extra/yassl/taocrypt/test/test

extra/yassl/testsuite/testsuite

client/mysql_upgrade

sql/share/iso639-2.txt

sql/share/fixerrmsg.pl

include/config-win.h

+1 −0
Original line number Diff line number Diff line
@@ -384,6 +384,7 @@ inline double ulonglong2double(ulonglong value) 


#define FN_LIBCHAR	'\\'

#define FN_ROOTDIR	"\\"

#define FN_DEVCHAR	':'

#define FN_NETWORK_DRIVES	/* Uses \\ to indicate network drives */

#define FN_NO_CASE_SENCE	/* Files are not case-sensitive */

#define OS_FILE_LIMIT	2048

include/my_global.h

+0 −1
Original line number Diff line number Diff line
@@ -599,7 +599,6 @@ typedef SOCKET_SIZE_TYPE size_socket; 
#define FN_HOMELIB	'~'	/* ~/ is used as abbrev for home dir */

#define FN_CURLIB	'.'	/* ./ is used as abbrev for current dir */

#define FN_PARENTDIR	".."	/* Parent directory; Must be a string */

#define FN_DEVCHAR	':'



#ifndef FN_LIBCHAR

#ifdef __EMX__

mysql-test/r/create.result

+14 −0
Original line number Diff line number Diff line
@@ -773,3 +773,17 @@ Warnings: 
Warning	1071	Specified key was too long; max key length is 765 bytes

insert into t1 values('aaa');

drop table t1;

drop table if exists `about:text`;

create table `about:text` ( 

_id int not null auto_increment,

`about:text` varchar(255) not null default '',

primary key (_id)

);

show create table `about:text`;

Table	Create Table

about:text	CREATE TABLE `about:text` (

  `_id` int(11) NOT NULL auto_increment,

  `about:text` varchar(255) NOT NULL default '',

  PRIMARY KEY  (`_id`)

) ENGINE=MyISAM DEFAULT CHARSET=latin1

drop table `about:text`;

mysql-test/t/create.test

+15 −0
Original line number Diff line number Diff line
@@ -674,4 +674,19 @@ create table t1(f1 varchar(800) binary not null, key(f1)) engine = innodb 
insert into t1 values('aaa');

drop table t1;



#

# Bug#19479:mysqldump creates invalid dump

#

--disable_warnings

drop table if exists `about:text`;

--enable_warnings

create table `about:text` ( 

_id int not null auto_increment,

`about:text` varchar(255) not null default '',

primary key (_id)

);



show create table `about:text`; 

drop table `about:text`;



# End of 5.0 tests