Commit 5c2d49db authored by unknown's avatar unknown
Browse files

bug #25492 (Invalid deallocation in mysql_stmt_fetch()) 

Additional patch.
mysql_flush_use_result() fixed.


libmysqld/lib_sql.cc:
  now emb_flush_use_result() uses emb_free_rows()
  duplicating code removed
parent fd76e148

libmysqld/lib_sql.cc

+8 −14
Original line number Diff line number Diff line
@@ -69,10 +69,14 @@ void embedded_get_error(MYSQL *mysql) 


static void emb_free_rows(THD *thd)

{

  if (!thd->data)

    return;



  if (thd->current_stmt)

    free_root(&thd->data->alloc,MYF(0));

  else

    free_rows(thd->data);

  thd->data= NULL;

}
@@ -86,11 +90,8 @@ emb_advanced_command(MYSQL *mysql, enum enum_server_command command, 
  THD *thd=(THD *) mysql->thd;

  NET *net= &mysql->net;



  if (thd->data)

  {

  emb_free_rows(thd);

    thd->data= 0;

  }



  /* Check that we are calling the client functions in right order */

  if (mysql->status != MYSQL_STATUS_READY)

  {
@@ -143,13 +144,7 @@ emb_advanced_command(MYSQL *mysql, enum enum_server_command command, 


static void emb_flush_use_result(MYSQL *mysql)

{

  MYSQL_DATA *data= ((THD*)(mysql->thd))->data;



  if (data)

  {

    free_rows(data);

    ((THD*)(mysql->thd))->data= NULL;

  }

  emb_free_rows((THD*) (mysql->thd));

}



static MYSQL_DATA *
@@ -304,7 +299,6 @@ int emb_unbuffered_fetch(MYSQL *mysql, char **row) 
static void emb_free_embedded_thd(MYSQL *mysql)

{

  THD *thd= (THD*)mysql->thd;

  if (thd->data)

  emb_free_rows(thd);

  thread_count--;

  delete thd;