Commit 605f7061 authored by unknown's avatar unknown
Browse files

BUG#10831 ndb mgmd LogDestination maxfiles does not rotate logs properly 


ndb/src/common/util/File.cpp:
  my_stat returns NULL on failure, not non-zero.
  
  i.e. exactly the opposite of stat(2).
  
  providing confusion for unix programmers, who expect errors to be non-zero.
  
  Clean up File_class::exists(char*) to use the my_stat interface properly.
parent 5b77d9b8

ndb/src/common/util/File.cpp

+3 −23
Original line number Diff line number Diff line
@@ -28,29 +28,9 @@ 
bool 

File_class::exists(const char* aFileName)

{

  bool rc = true;

#ifdef USE_MY_STAT_STRUCT

  struct my_stat stmp;

#else

  struct stat stmp;

#endif

  if (my_stat(aFileName, &stmp, MYF(0)) != 0)

  {

    rc = false;

  }

  MY_STAT stmp;



  /*

  File f;

  if (!f.open(aFileName, "r"))  

  {

    rc = (errno == ENOENT ? false : true);

  }

  else  

  {

    f.close();

  }

  */

  return rc;

  return (my_stat(aFileName, &stmp, MYF(0))!=NULL);

}



long