Commit 613dd50a authored by unknown's avatar unknown
Browse files

Finalize storage engine plugins 

Give BerkeleyDB savepoints
Remove "enum db_type" from most of the code


storage/example/ha_example.h:
  Rename: sql/examples/ha_example.h -> storage/example/ha_example.h
storage/csv/ha_tina.h:
  Rename: sql/examples/ha_tina.h -> storage/csv/ha_tina.h
config/ac-macros/storage.m4:
  if hton name is "no", then we don't install it as a builtin
configure.in:
  pluggable changes
include/plugin.h:
  version field
mysql-test/r/bdb.result:
  savepoint results copied from innodb test
mysql-test/r/information_schema.result:
  PLUGINS information schema
mysql-test/r/information_schema_db.result:
  PLUGINS information schema
mysql-test/t/bdb.test:
  savepoint test copied from innodb test
sql/Makefile.am:
  tina and example are not here anymore
sql/authors.h:
  minor tweek
sql/ha_archive.cc:
  remove unwanted handlerton entries
sql/ha_berkeley.cc:
  remove unwanted handlerton entries
  support for savepoints
  changes to show logs
sql/ha_blackhole.cc:
  remove unwanted handlerton entries
sql/ha_federated.cc:
  remove unwanted handlerton entries
sql/ha_heap.cc:
  remove unwanted handlerton entries
sql/ha_innodb.cc:
  remove unwanted handlerton entries
  changes for show status
sql/ha_myisam.cc:
  remove unwanted handlerton entries
sql/ha_myisammrg.cc:
  remove unwanted handlerton entries
sql/ha_ndbcluster.cc:
  remove unwanted handlerton entries
  changes to stat_print
sql/ha_partition.cc:
  remove unwanted handlerton entries
  bye bye enum db_type
sql/ha_partition.h:
  bye bye enum db_type
sql/handler.cc:
  remove unwanted handlerton entries
  bye bye enum db_type
sql/handler.h:
  remove unwanted handlerton entries
  bye bye enum db_type
  changes to stat_print_fn
sql/item_sum.cc:
  bye bye enum db_type
sql/log.cc:
  remove unwanted handlerton entries
sql/mysql_priv.h:
  bye bye enum db_type
sql/mysqld.cc:
  bye bye enum db_type
  reorder plugin initialization
sql/set_var.cc:
  bye bye enum db_type
sql/set_var.h:
  bye bye enum db_type
sql/sql_base.cc:
  bye bye enum db_type
sql/sql_cache.cc:
  bye bye enum db_type
sql/sql_class.h:
  bye bye enum db_type
sql/sql_delete.cc:
  bye bye enum db_type
sql/sql_insert.cc:
  bye bye enum db_type
sql/sql_lex.h:
  show plugin
sql/sql_parse.cc:
  bye bye enum db_type
sql/sql_partition.cc:
  bye bye enum db_type
sql/sql_plugin.cc:
  loadable storage engines
sql/sql_plugin.h:
  loadable storage engines
sql/sql_rename.cc:
  bye bye enum db_type
sql/sql_select.cc:
  bye bye enum db_type
sql/sql_show.cc:
  SHOW PLUGIN
  PLUGINS information schema
  changes to show engines
sql/sql_table.cc:
  bye bye enum db_type
sql/sql_view.cc:
  bye bye enum db_type
sql/sql_view.h:
  bye bye enum db_type
sql/sql_yacc.yy:
  bye bye enum db_type
sql/table.cc:
  bye bye enum db_type
sql/table.h:
  bye bye enum db_type
sql/unireg.cc:
  bye bye enum db_type
storage/csv/ha_tina.cc:
  make tina into a loadable plugin
storage/example/ha_example.cc:
  make into a plugin
storage/csv/Makefile.am:
  New BitKeeper file ``storage/csv/Makefile.am''
storage/example/Makefile.am:
  New BitKeeper file ``storage/example/Makefile.am''
parent 9c81773b

config/ac-macros/storage.m4

+7 −4
Original line number Diff line number Diff line
@@ -34,11 +34,14 @@ AC_CACHE_CHECK([whether to use $2], [mysql_cv_use_]m4_bpatsubst([$3], -, _), 
[mysql_cv_use_]m4_bpatsubst([$3], -, _)=[$with_]m4_bpatsubst([$3], -, _))

AH_TEMPLATE([$5], [Build $2])

if test "[$mysql_cv_use_]m4_bpatsubst([$3], -, _)" != no; then

if test "$6" != "no"

then

  AC_DEFINE([$5])

  mysql_se_decls="${mysql_se_decls},$6"

  mysql_se_htons="${mysql_se_htons},&$6"

mysql_se_dirs="$mysql_se_dirs $7"

  mysql_se_objs="$mysql_se_objs $8"

fi

mysql_se_dirs="$mysql_se_dirs $7"

mysql_se_libs="$mysql_se_libs $9"

$10

fi

configure.in

+7 −2
Original line number Diff line number Diff line
@@ -2411,9 +2411,14 @@ MYSQL_STORAGE_ENGINE(innobase,,innodb,,,,storage/innobase,ha_innodb.o,[ dnl 
MYSQL_STORAGE_ENGINE(berkeley,,berkeley-db,,,,storage/bdb,,,[

  MYSQL_SETUP_BERKELEY_DB

])

MYSQL_STORAGE_ENGINE(example)

MYSQL_STORAGE_ENGINE(example,,,,,no,storage/example,,,[

  AC_CONFIG_FILES(storage/example/Makefile)

])

MYSQL_STORAGE_ENGINE(archive)

MYSQL_STORAGE_ENGINE(csv,,,,,tina_hton,,ha_tina.o)

dnl MYSQL_STORAGE_ENGINE(csv,,,,,tina_hton,,ha_tina.o)

MYSQL_STORAGE_ENGINE(csv,,,,,no,storage/csv,,,[

  AC_CONFIG_FILES(storage/csv/Makefile)

])

MYSQL_STORAGE_ENGINE(blackhole)

MYSQL_STORAGE_ENGINE(federated)

MYSQL_STORAGE_ENGINE(ndbcluster,,ndbcluster,,,,storage/ndb,,,[

include/plugin.h

+1 −0
Original line number Diff line number Diff line
@@ -51,6 +51,7 @@ struct st_mysql_plugin 
  int type;             /* the plugin type (a MYSQL_XXX_PLUGIN value)   */

  void *info;           /* pointer to type-specific plugin descriptor   */

  const char *name;     /* plugin name                                  */

  uint version;         /* plugin version                               */

  const char *author;   /* plugin author (for SHOW PLUGINS)             */

  const char *descr;    /* general descriptive text (for SHOW PLUGINS ) */

  int (*init)(void);    /* the function to invoke when plugin is loaded */

mysql-test/r/bdb.result

+34 −0
Original line number Diff line number Diff line
@@ -285,6 +285,40 @@ n 
4

5

6

set autocommit=0;

begin;

savepoint `my_savepoint`;

insert into t1 values (7);

savepoint `savept2`;

insert into t1 values (3);

select n from t1;

n

3

4

5

6

7

savepoint savept3;

rollback to savepoint savept2;

rollback to savepoint savept3;

ERROR 42000: SAVEPOINT savept3 does not exist

rollback to savepoint savept2;

release savepoint `my_savepoint`;

select n from t1;

n

4

5

6

7

rollback to savepoint `my_savepoint`;

ERROR 42000: SAVEPOINT my_savepoint does not exist

rollback to savepoint savept2;

ERROR 42000: SAVEPOINT savept2 does not exist

insert into t1 values (8);

savepoint sv;

commit;

savepoint sv;

set autocommit=1;

rollback;

drop table t1;

create table t1 ( id int NOT NULL PRIMARY KEY, nom varchar(64)) engine=BDB;

mysql-test/r/information_schema.result

+4 −2
Original line number Diff line number Diff line
@@ -42,6 +42,7 @@ COLLATION_CHARACTER_SET_APPLICABILITY 
COLUMNS

COLUMN_PRIVILEGES

KEY_COLUMN_USAGE

PLUGINS

ROUTINES

SCHEMATA

SCHEMA_PRIVILEGES
@@ -723,7 +724,7 @@ CREATE TABLE t_crashme ( f1 BIGINT); 
CREATE VIEW a1 (t_CRASHME) AS SELECT f1 FROM t_crashme GROUP BY f1;

CREATE VIEW a2 AS SELECT t_CRASHME FROM a1;

count(*)

102

103

drop view a2, a1;

drop table t_crashme;

select table_schema,table_name, column_name from
@@ -731,6 +732,7 @@ information_schema.columns 
where data_type = 'longtext';

table_schema	table_name	column_name

information_schema	COLUMNS	COLUMN_TYPE

information_schema	PLUGINS	PLUGIN_DESCRIPTION

information_schema	ROUTINES	ROUTINE_DEFINITION

information_schema	ROUTINES	SQL_MODE

information_schema	TRIGGERS	ACTION_CONDITION
@@ -793,7 +795,7 @@ delete from mysql.db where user='mysqltest_4'; 
flush privileges;

SELECT table_schema, count(*) FROM information_schema.TABLES GROUP BY TABLE_SCHEMA;

table_schema	count(*)

information_schema	16

information_schema	17

mysql	18

create table t1 (i int, j int);

create trigger trg1 before insert on t1 for each row