Commit 62be4f5e authored by unknown's avatar unknown
Browse files

Fix for verification tests: loss of decimal places should not 

return an error
parent b3a2a3d6

libmysql/libmysql.c

+6 −7
Original line number Diff line number Diff line
@@ -3656,8 +3656,6 @@ static void fetch_long_with_conversion(MYSQL_BIND *param, MYSQL_FIELD *field, 
  }

}



#define MY_TRUNC(val) (val < 0 ? - floor(-val) : floor(val))



/*

  Convert double/float column to supplied buffer of any type.
@@ -3674,6 +3672,7 @@ static void fetch_float_with_conversion(MYSQL_BIND *param, MYSQL_FIELD *field, 
                                        double value, int width)

{

  char *buffer= (char *)param->buffer;

  double val64 = (value < 0 ? -floor(-value) : floor(value));



  switch (param->buffer_type) {

  case MYSQL_TYPE_NULL: /* do nothing */
@@ -3689,7 +3688,7 @@ static void fetch_float_with_conversion(MYSQL_BIND *param, MYSQL_FIELD *field, 
      *buffer= (uint8) value;

    else

      *buffer= (int8) value;

    *param->error= MY_TRUNC(value) != (param->is_unsigned ? (double) ((uint8) *buffer) :

    *param->error= val64 != (param->is_unsigned ? (double)((uint8) *buffer) :

                                                  (double)((int8) *buffer));

    break;

  case MYSQL_TYPE_SHORT:
@@ -3703,7 +3702,7 @@ static void fetch_float_with_conversion(MYSQL_BIND *param, MYSQL_FIELD *field, 
      short data= (short) value;

      shortstore(buffer, data);

    }

    *param->error= MY_TRUNC(value) != (param->is_unsigned ? (double) (*(ushort*) buffer):

    *param->error= val64 != (param->is_unsigned ? (double) (*(ushort*) buffer):

                                                  (double) (*(short*) buffer));

    break;

  case MYSQL_TYPE_LONG:
@@ -3717,7 +3716,7 @@ static void fetch_float_with_conversion(MYSQL_BIND *param, MYSQL_FIELD *field, 
      int32 data= (int32) value;

      longstore(buffer, data);

    }

    *param->error= MY_TRUNC(value) != (param->is_unsigned ? (double) (*(uint32*) buffer):

    *param->error= val64 != (param->is_unsigned ? (double) (*(uint32*) buffer):

                                                  (double) (*(int32*) buffer));

      break;

  case MYSQL_TYPE_LONGLONG:
@@ -3731,7 +3730,7 @@ static void fetch_float_with_conversion(MYSQL_BIND *param, MYSQL_FIELD *field, 
      longlong data= (longlong) value;

      longlongstore(buffer, data);

    }

    *param->error= MY_TRUNC(value) != (param->is_unsigned ?

    *param->error= val64 != (param->is_unsigned ?

                             ulonglong2double(*(ulonglong*) buffer) :

                             (double) (*(longlong*) buffer));

    break;

tests/mysql_client_test.c

+2 −3
Original line number Diff line number Diff line
@@ -3654,8 +3654,8 @@ static void test_bind_result_ext1() 
  check_execute(stmt, rc);



  rc= mysql_stmt_fetch(stmt);

  DIE_UNLESS(rc == MYSQL_DATA_TRUNCATED);

  DIE_UNLESS(bind[4].error_value == 1);

  printf("rc=%d\n", rc);

  DIE_UNLESS(rc == 0);



  if (!opt_silent)

  {
@@ -12462,7 +12462,6 @@ static void test_truncation() 


  /* double -> longlong: fractional part is lost */

  DIE_UNLESS(++bind < bind_array + bind_count);

  DIE_UNLESS(*bind->error && * (longlong*) bind->buffer == 123);



  /* double -> ulonglong, negative fp number to unsigned integer */

  DIE_UNLESS(++bind < bind_array + bind_count);