Commit 791a5d94 authored by unknown's avatar unknown
Browse files

Fixed compiler warnings 

Move plugin declarations after system functions have been checked
(Fixes problem with ndb_config failing becasue SHM is not declared)
Fixed some memory leaks


configure.in:
  Move plugin declarations after system functions have been checked
  (Fixes problem with ndb_config failing becasue SHM is not declared)
mysql-test/t/disabled.def:
  Disabled ndb_load, as it is in 5.0
  (Fails randomly in binlog_close_connection())
mysql-test/t/log_tables.test:
  Update error numbers
mysql-test/t/ndb_config.test:
  Moved test depending on SHM to ndb_config2.test
mysql-test/t/ndb_partition_error.test:
  Update error numbers
sql/event_timed.cc:
  Removed not needed line
sql/ha_berkeley.cc:
  Fixed compiler warning
sql/ha_heap.cc:
  Fixed compiler warning
sql/ha_innodb.cc:
  Fixed compiler warning
sql/ha_myisam.cc:
  Fixed compiler warning
sql/ha_myisammrg.cc:
  Fixed compiler warning
sql/ha_ndbcluster.cc:
  Fixed compiler warning
sql/ha_partition.cc:
  Fixed compiler warning
sql/mysql_priv.h:
  After merge fix
sql/mysqld.cc:
  Fixed memory leak in skip_grant.test
sql/share/errmsg.txt:
  Removed wrong error messages
sql/sql_lex.cc:
  More debugging
  Faster lex_end()
sql/sql_partition.cc:
  Fixed memory leak
sql/sql_view.cc:
  Fixed memory leak
mysql-test/r/ndb_config2.result:
  New BitKeeper file ``mysql-test/r/ndb_config2.result''
mysql-test/t/ndb_config2.test:
  New BitKeeper file ``mysql-test/t/ndb_config2.test''
parent 1f89605e

configure.in

+96 −96
Original line number Diff line number Diff line
@@ -48,92 +48,9 @@ czech danish dutch english estonian french german greek hungarian \ 
italian japanese korean norwegian norwegian-ny polish portuguese \

romanian russian serbian slovak spanish swedish ukrainian"



#--------------------------------------------------------------------

# Declare our plugin modules

#--------------------------------------------------------------------



MYSQL_STORAGE_ENGINE(archive,,  [Archive Storage Engine],

        [Archive Storage Engine], [max,max-no-ndb])

MYSQL_PLUGIN_DIRECTORY(archive, [storage/archive])

MYSQL_PLUGIN_STATIC(archive,    [libarchive.a])

MYSQL_PLUGIN_DYNAMIC(archive,   [ha_archive.la])



MYSQL_STORAGE_ENGINE(berkeley,  berkeley-db, [BerkeleyDB Storage Engine],

        [Transactional Tables using BerkeleyDB], [max,max-no-ndb])

MYSQL_PLUGIN_DIRECTORY(berkeley,[storage/bdb])

MYSQL_PLUGIN_STATIC(berkeley,   [[\$(bdb_libs_with_path)]])

MYSQL_PLUGIN_ACTIONS(berkeley,  [MYSQL_SETUP_BERKELEY_DB])



MYSQL_STORAGE_ENGINE(blackhole,,[Blackhole Storage Engine],

        [Basic Write-only Read-never tables], [max,max-no-ndb])

MYSQL_PLUGIN_DIRECTORY(blackhole, [storage/blackhole])

MYSQL_PLUGIN_STATIC(blackhole,  [libblackhole.a])

MYSQL_PLUGIN_DYNAMIC(blackhole, [ha_blackhole.la])



MYSQL_STORAGE_ENGINE(csv,,      [CSV Storage Engine],

        [Stores tables in text CSV format])

MYSQL_PLUGIN_DIRECTORY(csv,     [storage/csv])

MYSQL_PLUGIN_STATIC(csv,        [libcsv.a])

MYSQL_PLUGIN_MANDATORY(csv)     dnl Used for logging



MYSQL_STORAGE_ENGINE(example,,  [Example Storage Engine],

        [Skeleton for Storage Engines for developers], [max,max-no-ndb])

MYSQL_PLUGIN_DIRECTORY(example, [storage/example])

MYSQL_PLUGIN_STATIC(example,    [libexample.a])

MYSQL_PLUGIN_DYNAMIC(example,   [ha_example.la])



MYSQL_STORAGE_ENGINE(federated,,[Federated Storage Engine],

        [Connects to tables on remote MySQL servers], [max,max-no-ndb])



MYSQL_PLUGIN(ftexample,         [Simple Parser],

        [Simple full-text parser plugin])

MYSQL_PLUGIN_DIRECTORY(ftexample, [plugin/fulltext])

MYSQL_PLUGIN_DYNAMIC(ftexample, [mypluglib.la])



MYSQL_STORAGE_ENGINE(heap,no,   [Memory Storage Engine],

        [Volatile memory based tables])

MYSQL_PLUGIN_DIRECTORY(heap,    [storage/heap])

MYSQL_PLUGIN_STATIC(heap,       [libheap.a])

MYSQL_PLUGIN_MANDATORY(heap)    dnl Memory tables



MYSQL_STORAGE_ENGINE(innobase,  innodb, [InnoDB Storage Engine],

        [Transactional Tables using InnoDB], [max,max-no-ndb])

MYSQL_PLUGIN_DIRECTORY(innobase, [storage/innobase])

MYSQL_PLUGIN_STATIC(innobase,   [libinnobase.a])

MYSQL_PLUGIN_ACTIONS(innobase,  [

  AC_CHECK_LIB(rt, aio_read, [innodb_system_libs="-lrt"])

  AC_SUBST(innodb_system_libs)

])



MYSQL_STORAGE_ENGINE(myisam,no, [MyISAM Storage Engine],

        [Traditional non-transactional MySQL tables])

MYSQL_PLUGIN_DIRECTORY(myisam,  [storage/myisam])

MYSQL_PLUGIN_STATIC(myisam,     [libmyisam.a])

MYSQL_PLUGIN_MANDATORY(myisam)  dnl Default



MYSQL_STORAGE_ENGINE(myisammrg,no,[MyISAM MERGE Engine],

        [Merge multiple MySQL tables into one])

MYSQL_PLUGIN_DIRECTORY(myisammrg,[storage/myisammrg])

MYSQL_PLUGIN_STATIC(myisammrg,  [libmyisammrg.a])

MYSQL_PLUGIN_MANDATORY(myisammrg)



MYSQL_STORAGE_ENGINE(ndbcluster, ndbcluster, [Cluster Storage Engine],

        [High Availability Clustered tables], [max])

MYSQL_PLUGIN_DIRECTORY(ndbcluster,[storage/ndb])

MYSQL_PLUGIN_STATIC(ndbcluster, [[\$(ndbcluster_libs) \$(ndbcluster_system_libs) \$(NDB_SCI_LIBS)]])

MYSQL_PLUGIN_ACTIONS(ndbcluster,[MYSQL_SETUP_NDBCLUSTER])



MYSQL_STORAGE_ENGINE(partition, partition, [Partition Support],

        [MySQL Partitioning Support], [max,max-no-ndb])



dnl -- ndbcluster requires partition to be enabled

MYSQL_PLUGIN_DEPENDS(ndbcluster, [partition])





#####

#####





AC_SUBST(MYSQL_NO_DASH_VERSION)

AC_SUBST(MYSQL_BASE_VERSION)

AC_SUBST(MYSQL_VERSION_ID)
@@ -762,16 +679,6 @@ MYSQL_SYS_LARGEFILE 
# Types that must be checked AFTER large file support is checked

AC_TYPE_SIZE_T



#--------------------------------------------------------------------

# Check for requested features

#--------------------------------------------------------------------



MYSQL_CHECK_BIG_TABLES

MYSQL_CHECK_MAX_INDEXES

MYSQL_CHECK_REPLICATION



MYSQL_CONFIGURE_PLUGINS([none])



#--------------------------------------------------------------------

# Check for system header files

#--------------------------------------------------------------------
@@ -2288,6 +2195,102 @@ then 
fi

AC_MSG_RESULT("$netinet_inc")



#--------------------------------------------------------------------

# Check for requested features

#--------------------------------------------------------------------



MYSQL_CHECK_BIG_TABLES

MYSQL_CHECK_MAX_INDEXES

MYSQL_CHECK_REPLICATION

MYSQL_CHECK_VIO

MYSQL_CHECK_OPENSSL

MYSQL_CHECK_YASSL



#--------------------------------------------------------------------

# Declare our plugin modules

# Has to be done late, as the plugin may need to check for existence of

# functions tested above

#--------------------------------------------------------------------



MYSQL_STORAGE_ENGINE(archive,,  [Archive Storage Engine],

        [Archive Storage Engine], [max,max-no-ndb])

MYSQL_PLUGIN_DIRECTORY(archive, [storage/archive])

MYSQL_PLUGIN_STATIC(archive,    [libarchive.a])

MYSQL_PLUGIN_DYNAMIC(archive,   [ha_archive.la])



MYSQL_STORAGE_ENGINE(berkeley,  berkeley-db, [BerkeleyDB Storage Engine],

        [Transactional Tables using BerkeleyDB], [max,max-no-ndb])

MYSQL_PLUGIN_DIRECTORY(berkeley,[storage/bdb])

MYSQL_PLUGIN_STATIC(berkeley,   [[\$(bdb_libs_with_path)]])

MYSQL_PLUGIN_ACTIONS(berkeley,  [MYSQL_SETUP_BERKELEY_DB])



MYSQL_STORAGE_ENGINE(blackhole,,[Blackhole Storage Engine],

        [Basic Write-only Read-never tables], [max,max-no-ndb])

MYSQL_PLUGIN_DIRECTORY(blackhole, [storage/blackhole])

MYSQL_PLUGIN_STATIC(blackhole,  [libblackhole.a])

MYSQL_PLUGIN_DYNAMIC(blackhole, [ha_blackhole.la])



MYSQL_STORAGE_ENGINE(csv,,      [CSV Storage Engine],

        [Stores tables in text CSV format])

MYSQL_PLUGIN_DIRECTORY(csv,     [storage/csv])

MYSQL_PLUGIN_STATIC(csv,        [libcsv.a])

MYSQL_PLUGIN_MANDATORY(csv)     dnl Used for logging



MYSQL_STORAGE_ENGINE(example,,  [Example Storage Engine],

        [Skeleton for Storage Engines for developers], [max,max-no-ndb])

MYSQL_PLUGIN_DIRECTORY(example, [storage/example])

MYSQL_PLUGIN_STATIC(example,    [libexample.a])

MYSQL_PLUGIN_DYNAMIC(example,   [ha_example.la])



MYSQL_STORAGE_ENGINE(federated,,[Federated Storage Engine],

        [Connects to tables on remote MySQL servers], [max,max-no-ndb])



MYSQL_PLUGIN(ftexample,         [Simple Parser],

        [Simple full-text parser plugin])

MYSQL_PLUGIN_DIRECTORY(ftexample, [plugin/fulltext])

MYSQL_PLUGIN_DYNAMIC(ftexample, [mypluglib.la])



MYSQL_STORAGE_ENGINE(heap,no,   [Memory Storage Engine],

        [Volatile memory based tables])

MYSQL_PLUGIN_DIRECTORY(heap,    [storage/heap])

MYSQL_PLUGIN_STATIC(heap,       [libheap.a])

MYSQL_PLUGIN_MANDATORY(heap)    dnl Memory tables



MYSQL_STORAGE_ENGINE(innobase,  innodb, [InnoDB Storage Engine],

        [Transactional Tables using InnoDB], [max,max-no-ndb])

MYSQL_PLUGIN_DIRECTORY(innobase, [storage/innobase])

MYSQL_PLUGIN_STATIC(innobase,   [libinnobase.a])

MYSQL_PLUGIN_ACTIONS(innobase,  [

  AC_CHECK_LIB(rt, aio_read, [innodb_system_libs="-lrt"])

  AC_SUBST(innodb_system_libs)

])



MYSQL_STORAGE_ENGINE(myisam,no, [MyISAM Storage Engine],

        [Traditional non-transactional MySQL tables])

MYSQL_PLUGIN_DIRECTORY(myisam,  [storage/myisam])

MYSQL_PLUGIN_STATIC(myisam,     [libmyisam.a])

MYSQL_PLUGIN_MANDATORY(myisam)  dnl Default



MYSQL_STORAGE_ENGINE(myisammrg,no,[MyISAM MERGE Engine],

        [Merge multiple MySQL tables into one])

MYSQL_PLUGIN_DIRECTORY(myisammrg,[storage/myisammrg])

MYSQL_PLUGIN_STATIC(myisammrg,  [libmyisammrg.a])

MYSQL_PLUGIN_MANDATORY(myisammrg)



MYSQL_STORAGE_ENGINE(ndbcluster, ndbcluster, [Cluster Storage Engine],

        [High Availability Clustered tables], [max])

MYSQL_PLUGIN_DIRECTORY(ndbcluster,[storage/ndb])

MYSQL_PLUGIN_STATIC(ndbcluster, [[\$(ndbcluster_libs) \$(ndbcluster_system_libs) \$(NDB_SCI_LIBS)]])

MYSQL_PLUGIN_ACTIONS(ndbcluster,[MYSQL_SETUP_NDBCLUSTER])



MYSQL_STORAGE_ENGINE(partition, partition, [Partition Support],

        [MySQL Partitioning Support], [max,max-no-ndb])



dnl -- ndbcluster requires partition to be enabled

MYSQL_PLUGIN_DEPENDS(ndbcluster, [partition])



MYSQL_CONFIGURE_PLUGINS([none])



# Only build client code?

AC_ARG_WITH(server,

    [  --without-server        Only build the client.],
@@ -2353,9 +2356,6 @@ fi 
AC_SUBST(tools_dirs)



#MYSQL_CHECK_CPU

MYSQL_CHECK_VIO

MYSQL_CHECK_OPENSSL

MYSQL_CHECK_YASSL



libmysqld_dirs=

linked_libmysqld_targets=

mysql-test/r/ndb_config2.result

0 → 100644
+1 −0
Original line number Diff line number Diff line 
shm,3,4,35,3 shm,3,5,35,3 shm,3,6,35,3 shm,4,5,35,4 shm,4,6,35,4 shm,5,6,35,5 tcp,11,3,55,3 tcp,11,4,55,4 tcp,11,5,55,5 tcp,11,6,55,6 tcp,12,3,55,3 tcp,12,4,55,4 tcp,12,5,55,5 tcp,12,6,55,6 tcp,13,3,55,3 tcp,13,4,55,4 tcp,13,5,55,5 tcp,13,6,55,6 tcp,14,3,55,3 tcp,14,4,55,4 tcp,14,5,55,5 tcp,14,6,55,6 tcp,15,3,55,3 tcp,15,4,55,4 tcp,15,5,55,5 tcp,15,6,55,6 tcp,1,3,55,1 tcp,1,4,55,1 tcp,1,5,55,1 tcp,1,6,55,1 tcp,2,3,55,2 tcp,2,4,55,2 tcp,2,5,55,2 tcp,2,6,55,2

mysql-test/t/disabled.def

+2 −1
Original line number Diff line number Diff line
@@ -18,6 +18,7 @@ ndb_autodiscover2 : BUG#18952 2006-02-16 jmiller Needs to be fixed w.r.t 
ndb_binlog_discover      : BUG#19395 2006-04-28 tomas/knielsen mysqld does not always detect cluster shutdown

#ndb_cache2               : BUG#18597 2006-03-28 brian simultaneous drop table and ndb statistics update triggers node failure

#ndb_cache_multi2         : BUG#18597 2006-04-10 kent  simultaneous drop table and ndb statistics update triggers node failure

ndb_load                  : Bug#17233 (This is also in 5.0)

partition_03ndb          : BUG#16385 2006-03-24 mikael Partitions: crash when updating a range partitioned NDB table

ps_7ndb                  : BUG#18950 2006-02-16 jmiller create table like does not obtain LOCK_open

rpl_ndb_2innodb          : BUG#19227 2006-04-20 pekka pk delete apparently not replicated

mysql-test/t/log_tables.test

+4 −4
Original line number Diff line number Diff line
@@ -63,10 +63,10 @@ flush logs; 
# check locking of the log tables

#



--error 1533

--error ER_CANT_WRITE_LOCK_LOG_TABLE

lock tables mysql.general_log WRITE;



--error 1533

--error ER_CANT_WRITE_LOCK_LOG_TABLE

lock tables mysql.slow_log WRITE;



#
@@ -75,10 +75,10 @@ lock tables mysql.slow_log WRITE; 
# tables are always opened and locked by the logger.

#



--error 1534

--error ER_CANT_READ_LOCK_LOG_TABLE

lock tables mysql.general_log READ;



--error 1534

--error ER_CANT_READ_LOCK_LOG_TABLE

lock tables mysql.slow_log READ;



#

mysql-test/t/ndb_config.test

+0 −6
Original line number Diff line number Diff line
@@ -15,9 +15,3 @@ 
--exec $NDB_TOOLS_DIR/ndb_config --defaults-group-suffix=.cluster0 --defaults-file=$MYSQL_TEST_DIR/std_data/ndb_config_mycnf2.cnf --query=type,nodeid,host --mycnf 2> /dev/null

--exec $NDB_TOOLS_DIR/ndb_config --defaults-group-suffix=.cluster1 --defaults-file=$MYSQL_TEST_DIR/std_data/ndb_config_mycnf2.cnf --query=type,nodeid,host --mycnf 2> /dev/null

--exec $NDB_TOOLS_DIR/ndb_config --defaults-group-suffix=.cluster2 --defaults-file=$MYSQL_TEST_DIR/std_data/ndb_config_mycnf2.cnf --query=type,nodeid,host --mycnf 2> /dev/null
 


# Following doesn't work in all configurations



--disable_parsing

--exec $NDB_TOOLS_DIR/ndb_config --defaults-group-suffix=.cluster2 --defaults-file=$MYSQL_TEST_DIR/std_data/ndb_config_mycnf2.cnf --ndb-shm --connections --query=type,nodeid1,nodeid2,group,nodeidserver --mycnf 2> /dev/null

--enable_parsing