Commit 7a37eeae authored by unknown's avatar unknown
Browse files

Fix for bug #20665 All commands supported in Stored Procedures 

should work in Prepared Statements. Post-review changeset.

Problem: There are some commands which are avaiable to be executed in SP
         but cannot be prepared. This patch fixes this and makes it possible
         prepare these statements.

Changes: The commands later are made available in PS. RESET has been forbidden
         in SF/Trigger.

Solution: All current server commands where checked and those missing (see later)
          we added. Tests for all of the commands with repeated executions were
          added - testing with SP, SF and PS.

SHOW BINLOG EVENTS
SHOW (MASTER | SLAVE) STATUS
SHOW (MASTER | BINARY) LOGS
SHOW (PROCEDURE | FUNCTION) CODE (parsable only in debug builds)
SHOW CREATE (PROCEDURE | FUNCTION | EVENT | TABLE | VIEW)
SHOW (AUTHORS | CONTRIBUTORS | WARNINGS | ERRORS)
CHANGE MASTER
RESET (MASTER | SLAVE | QUERY CACHE)
SLAVE (START | STOP)
CHECKSUM (TABLE | TABLES)
INSTALL PLUGIN
UNINSTALL PLUGIN
CACHE INDEX
LOAD INDEX INTO CACHE
GRANT
REVOKE
KILL
(CREATE | RENAME | DROP) DATABASE
(CREATE | RENAME | DROP) USER
FLUSH (TABLE | TABLES | TABLES WITH READ LOCK | HOSTS | PRIVILEGES |
       LOGS | STATUS | MASTER | SLAVE | DES_KEY_FILE | USER_RESOURCES)


mysql-test/r/ps.result:
  update result
mysql-test/r/ps_1general.result:
  update result
mysql-test/r/ps_grant.result:
  update result
mysql-test/r/sp-dynamic.result:
  update result
mysql-test/t/ps.test:
  Add more statements, probably all currently missing which are possible in
  a SP but not preparable.
  Every statement is tested in a SP, in a SF and attempted to prepare.
mysql-test/t/ps_1general.test:
  - Enable some of the statements, which are already possible in SP.
  - 1295 -> ER_UNSUPPORTED_PS
mysql-test/t/ps_grant.test:
  Enable statements already possible in SP.
sql/sp_head.cc:
  - Reorder to keep some alphabet order.
  - Add missing SHOW_SCHEDULER_STATUS.
sql/sql_prepare.cc:
  Add possibility to prepare statements, which are already allowed in SP.
parent 96aef62c

mysql-test/r/ps.result

+882 −0

File changed.

Preview size limit exceeded, changes collapsed.

mysql-test/r/ps_1general.result

+0 −12
Original line number Diff line number Diff line
@@ -308,17 +308,11 @@ prepare stmt4 from ' show engine bdb logs '; 
execute stmt4;

prepare stmt4 from ' show grants for user ';

prepare stmt4 from ' show create table t2 ';

ERROR HY000: This command is not supported in the prepared statement protocol yet

prepare stmt4 from ' show master status ';

ERROR HY000: This command is not supported in the prepared statement protocol yet

prepare stmt4 from ' show master logs ';

ERROR HY000: This command is not supported in the prepared statement protocol yet

prepare stmt4 from ' show slave status ';

ERROR HY000: This command is not supported in the prepared statement protocol yet

prepare stmt4 from ' show warnings limit 20 ';

ERROR HY000: This command is not supported in the prepared statement protocol yet

prepare stmt4 from ' show errors limit 20 ';

ERROR HY000: This command is not supported in the prepared statement protocol yet

prepare stmt4 from ' show storage engines ';

execute stmt4;

drop table if exists t5;
@@ -387,10 +381,8 @@ ERROR 42000: You have an error in your SQL syntax; check the manual that corresp 
prepare stmt4 from ' use test ' ;

ERROR HY000: This command is not supported in the prepared statement protocol yet

prepare stmt3 from ' create database mysqltest ';

ERROR HY000: This command is not supported in the prepared statement protocol yet

create database mysqltest ;

prepare stmt3 from ' drop database mysqltest ';

ERROR HY000: This command is not supported in the prepared statement protocol yet

drop database mysqltest ;

prepare stmt3 from ' describe t2 ';

execute stmt3;
@@ -412,7 +404,6 @@ execute stmt1 ; 
prepare stmt1 from ' optimize table t1 ' ;

prepare stmt1 from ' analyze table t1 ' ;

prepare stmt1 from ' checksum table t1 ' ;

ERROR HY000: This command is not supported in the prepared statement protocol yet

prepare stmt1 from ' repair table t1 ' ;

prepare stmt1 from ' restore table t1 from ''data.txt'' ' ;

ERROR HY000: This command is not supported in the prepared statement protocol yet
@@ -440,11 +431,8 @@ execute stmt5; 
1

SET sql_mode="";

prepare stmt1 from ' flush local privileges ' ;

ERROR HY000: This command is not supported in the prepared statement protocol yet

prepare stmt1 from ' reset query cache ' ;

ERROR HY000: This command is not supported in the prepared statement protocol yet

prepare stmt1 from ' KILL 0 ';

ERROR HY000: This command is not supported in the prepared statement protocol yet

prepare stmt1 from ' explain select a from t1 order by b ';

execute stmt1;

Catalog	Database	Table	Table_alias	Column	Column_alias	Type	Length	Max length	Is_null	Flags	Decimals	Charsetnr

mysql-test/r/ps_grant.result

+0 −3
Original line number Diff line number Diff line
@@ -78,13 +78,10 @@ ERROR 42000: There is no such grant defined for user 'second_user' on host 'loca 
drop database mysqltest;

prepare stmt3 from ' grant all on test.t1 to drop_user@localhost

identified by ''looser'' ';

ERROR HY000: This command is not supported in the prepared statement protocol yet

grant all on test.t1 to drop_user@localhost

identified by 'looser' ;

prepare stmt3 from ' revoke all privileges on test.t1 from 

drop_user@localhost ';

ERROR HY000: This command is not supported in the prepared statement protocol yet

revoke all privileges on test.t1 from drop_user@localhost ;

prepare stmt3 from ' drop user drop_user@localhost ';

ERROR HY000: This command is not supported in the prepared statement protocol yet

drop user drop_user@localhost;

mysql-test/r/sp-dynamic.result

+2 −2
Original line number Diff line number Diff line
@@ -284,11 +284,11 @@ call p1()| 
select * from t1|

id	stmt_text	status

1	select 1	supported

2	flush tables	not supported

2	flush tables	supported

3	handler t1 open as ha	not supported

4	analyze table t1	supported

5	check table t1	not supported

6	checksum table t1	not supported

6	checksum table t1	supported

7	check table t1	not supported

8	optimize table t1	supported

9	repair table t1	supported

mysql-test/t/ps.test

+871 −0

File changed.

Preview size limit exceeded, changes collapsed.