Commit a4a651e1 authored by unknown's avatar unknown
Browse files

ndb - bug#23203 

  1) Handle not started nodes in dump 1000 (check for division by 0)
  2) Make sure to init variables in constructor


ndb/src/common/debugger/EventLogger.cpp:
  Handle not started nodes
ndb/src/kernel/blocks/dbacc/DbaccInit.cpp:
  Init variables in constructor
ndb/src/kernel/blocks/dbacc/DbaccMain.cpp:
  Handle not started nodes
ndb/src/kernel/blocks/dbtup/DbtupGen.cpp:
  Init variables in constructor
  Handle not started nodes
parent 2acf07aa

ndb/src/common/debugger/EventLogger.cpp

+2 −2
Original line number Diff line number Diff line
@@ -647,7 +647,7 @@ void getTextMemoryUsage(QQQQ) { 
  const int used = theData[3];

  const int total = theData[4];

  const int block = theData[5];

  const int percent = (used*100)/total;

  const int percent = total ? (used*100)/total : 0;

  

  BaseString::snprintf(m_text, m_text_len,

		       "%s usage %s %d%s(%d %dK pages of total %d)",

ndb/src/kernel/blocks/dbacc/DbaccInit.cpp

+1 −0
Original line number Diff line number Diff line
@@ -53,6 +53,7 @@ void Dbacc::initData() 
  tabrec = 0;

  undopage = 0;



  cnoOfAllocatedPages = cpagesize = 0;

  // Records with constant sizes

}//Dbacc::initData()

ndb/src/kernel/blocks/dbacc/DbaccMain.cpp

+1 −1
Original line number Diff line number Diff line
@@ -177,7 +177,7 @@ void Dbacc::execCONTINUEB(Signal* signal) 
  case ZREPORT_MEMORY_USAGE:{

    jam();

    static int c_currentMemUsed = 0;

    int now = (cnoOfAllocatedPages * 100)/cpagesize;

    int now = cpagesize ? (cnoOfAllocatedPages * 100)/cpagesize : 0;

    const int thresholds[] = { 99, 90, 80, 0};

    

    Uint32 i = 0;

ndb/src/kernel/blocks/dbtup/DbtupGen.cpp

+2 −1
Original line number Diff line number Diff line
@@ -142,6 +142,7 @@ Dbtup::Dbtup(const class Configuration & conf) 
  tablerec = 0;  

  tableDescriptor = 0;  

  undoPage = 0;

  cnoOfPage = cnoOfAllocatedPages = 0;

}//Dbtup::Dbtup()



Dbtup::~Dbtup()
@@ -526,7 +527,7 @@ void Dbtup::execCONTINUEB(Signal* signal) 
  case ZREPORT_MEMORY_USAGE:{

    ljam();

    static int c_currentMemUsed = 0;

    int now = (cnoOfAllocatedPages * 100)/cnoOfPage;

    int now = cnoOfPage ? (cnoOfAllocatedPages * 100)/cnoOfPage : 0;

    const int thresholds[] = { 100, 90, 80, 0 };

    

    Uint32 i = 0;