Commit b89feadf authored by unknown's avatar unknown
Browse files

BUG#8786 - ndb_autodiscover, post review 

  More explicit naming of variables


ndb/include/kernel/signaldata/AlterIndx.hpp:
  Add union to indicate where master node is passed in ref
ndb/include/kernel/signaldata/BuildIndx.hpp:
  Add union to indicate where master node is passed in ref
ndb/include/kernel/signaldata/CreateIndx.hpp:
  Add union to indicate where master node is passed in ref
ndb/include/kernel/signaldata/CreateTrig.hpp:
  Add union to indicate where master node is passed in ref
ndb/include/kernel/signaldata/DropIndx.hpp:
  Add union to indicate where master node is passed in ref
ndb/src/kernel/blocks/dbdict/Dbdict.cpp:
  Set error/master node also on BuildIndxRef
ndb/src/ndbapi/NdbDictionaryImpl.cpp:
  Use masterNodeId instead of errornode
parent 6b38100d

ndb/include/kernel/signaldata/AlterIndx.hpp

+4 −2
Original line number Diff line number Diff line
@@ -201,8 +201,10 @@ private: 
  //Uint32 m_indexVersion;

  Uint32 m_errorCode;

  Uint32 m_errorLine;

  union {

    Uint32 m_errorNode;



    Uint32 masterNodeId; // if NotMaster

  };

public:

  AlterIndxConf* getConf() {

    return &m_conf;

ndb/include/kernel/signaldata/BuildIndx.hpp

+2 −2
Original line number Diff line number Diff line
@@ -242,9 +242,8 @@ public: 
    AllocationFailure = 4252,

    InternalError = 4346

  };

  STATIC_CONST( SignalLength = BuildIndxConf::SignalLength + 1 );

  STATIC_CONST( SignalLength = BuildIndxConf::SignalLength + 2 );



private:

  //Uint32 m_userRef;

  //Uint32 m_connectionPtr;

  //Uint32 m_requestInfo;
@@ -253,6 +252,7 @@ private: 
  //Uint32 m_indexId;

  BuildIndxConf m_conf;

  Uint32 m_errorCode;

  Uint32 masterNodeId;



public:

  BuildIndxConf* getConf() {

ndb/include/kernel/signaldata/CreateIndx.hpp

+4 −2
Original line number Diff line number Diff line
@@ -220,8 +220,10 @@ public: 
  //Uint32 m_indexVersion;

  Uint32 m_errorCode;

  Uint32 m_errorLine;

  union {

    Uint32 m_errorNode;



    Uint32 masterNodeId; // If NotMaster

  };

public:

  CreateIndxConf* getConf() {

    return &m_conf;

ndb/include/kernel/signaldata/CreateTrig.hpp

+4 −2
Original line number Diff line number Diff line
@@ -311,8 +311,10 @@ private: 
  //Uint32 m_triggerInfo;

  Uint32 m_errorCode;

  Uint32 m_errorLine;

  union {

    Uint32 m_errorNode;



    Uint32 masterNodeId; // When NotMaster

  };

public:

  CreateTrigConf* getConf() {

    return &m_conf;

ndb/include/kernel/signaldata/DropIndx.hpp

+4 −2
Original line number Diff line number Diff line
@@ -185,8 +185,10 @@ public: 
  //Uint32 m_indexVersion;

  Uint32 m_errorCode;

  Uint32 m_errorLine;

  union {

    Uint32 m_errorNode;



    Uint32 masterNodeId;

  };

public:

  DropIndxConf* getConf() {

    return &m_conf;