Commit c8673b09 authored by unknown's avatar unknown
Browse files

Bug #21080: ALTER VIEW makes user restate SQL SECURITY mode, and ALGORITHM 

  When executing ALTER TABLE all the attributes of the view were overwritten.
  This is contrary to the user's expectations.
  So some of the view attributes are preserved now : namely security and 
  algorithm. This means that if they are not specified in ALTER VIEW
  their values are preserved from CREATE VIEW instead of being defaulted.


mysql-test/r/view.result:
  Bug #21080: ALTER VIEW makes user restate SQL SECURITY mode, and ALGORITHM
   - test suite
mysql-test/t/view.test:
  Bug #21080: ALTER VIEW makes user restate SQL SECURITY mode, and ALGORITHM
   - test suite
sql/sql_lex.h:
  Bug #21080: ALTER VIEW makes user restate SQL SECURITY mode, and ALGORITHM
   - must make create_view_suid a tristate : on/off/unspecified
sql/sql_view.cc:
  Bug #21080: ALTER VIEW makes user restate SQL SECURITY mode, and ALGORITHM
   - open the view to get it's attributes and put then as defaults 
     for ALTER VIEW
sql/sql_yacc.yy:
  Bug #21080: ALTER VIEW makes user restate SQL SECURITY mode, and ALGORITHM
   - must make create_view_suid a tristate : on/off/unspecified
sql/table.h:
  Bug #21080: ALTER VIEW makes user restate SQL SECURITY mode, and ALGORITHM
   - must make create_view_suid a tristate : on/off/unspecified
parent bc6fd749

mysql-test/r/view.result

+11 −0
Original line number Diff line number Diff line
@@ -2807,3 +2807,14 @@ yadda 
yad

DROP VIEW v1;

DROP TABLE t1;

CREATE TABLE t1 (x INT, y INT);

CREATE ALGORITHM=TEMPTABLE SQL SECURITY INVOKER VIEW v1 AS SELECT x FROM t1;

SHOW CREATE VIEW v1;

View	Create View

v1	CREATE ALGORITHM=TEMPTABLE DEFINER=`root`@`localhost` SQL SECURITY INVOKER VIEW `v1` AS select `t1`.`x` AS `x` from `t1`

ALTER VIEW v1 AS SELECT x, y FROM t1;

SHOW CREATE VIEW v1;

View	Create View

v1	CREATE ALGORITHM=TEMPTABLE DEFINER=`root`@`localhost` SQL SECURITY INVOKER VIEW `v1` AS select `t1`.`x` AS `x`,`t1`.`y` AS `y` from `t1`

DROP VIEW v1;

DROP TABLE t1;

mysql-test/t/view.test

+13 −0
Original line number Diff line number Diff line
@@ -2667,3 +2667,16 @@ SELECT * FROM v1; 
DROP VIEW v1;



DROP TABLE t1;



#

#Bug #21080: ALTER VIEW makes user restate SQL SECURITY mode, and ALGORITHM

#

CREATE TABLE t1 (x INT, y INT);

CREATE ALGORITHM=TEMPTABLE SQL SECURITY INVOKER VIEW v1 AS SELECT x FROM t1;

SHOW CREATE VIEW v1;



ALTER VIEW v1 AS SELECT x, y FROM t1;

SHOW CREATE VIEW v1;



DROP VIEW v1;

DROP TABLE t1;

sql/sql_lex.h

+1 −1
Original line number Diff line number Diff line
@@ -978,7 +978,7 @@ typedef struct st_lex : public Query_tables_list 
  /*

    view created to be run from definer (standard behaviour)

  */

  bool create_view_suid;

  uint8 create_view_suid;

  /* Characterstics of trigger being created */

  st_trg_chistics trg_chistics;

  /*

sql/sql_view.cc

+56 −0
Original line number Diff line number Diff line
@@ -155,6 +155,54 @@ bool check_duplicate_names(List<Item> &item_list, bool gen_unique_view_name) 
  DBUG_RETURN(TRUE);

}



/*

  Fill defined view parts



  SYNOPSIS

    fill_defined_view_parts()

      thd                current thread.

      view               view to operate on



  DESCRIPTION

    This function will initialize the parts of the view 

    definition that are not specified in ALTER VIEW

    to their values from CREATE VIEW.

    The view must be opened to get its definition.

    We use a copy of the view when opening because we want 

    to preserve the original view instance.



  RETURN VALUE

    TRUE                 can't open table

    FALSE                success

*/

static bool

fill_defined_view_parts (THD *thd, TABLE_LIST *view)

{

  LEX *lex= thd->lex;

  bool not_used;

  TABLE_LIST decoy;



  memcpy (&decoy, view, sizeof (TABLE_LIST));

  if (!open_table(thd, &decoy, thd->mem_root, &not_used, 0) &&

      !decoy.view)

  {

    return TRUE;

  }

  if (!lex->definer)

  {

    view->definer.host= decoy.definer.host;

    view->definer.user= decoy.definer.user;

    lex->definer= &view->definer;

  }

  if (lex->create_view_algorithm == VIEW_ALGORITHM_UNDEFINED)

    lex->create_view_algorithm= decoy.algorithm;

  if (lex->create_view_suid == VIEW_SUID_DEFAULT)

    lex->create_view_suid= decoy.view_suid ? 

      VIEW_SUID_DEFINER : VIEW_SUID_INVOKER;



  return FALSE;

}





/*

  Creating/altering VIEW procedure
@@ -207,7 +255,15 @@ bool mysql_create_view(THD *thd, 
  }



  if (mode != VIEW_CREATE_NEW)

  {

    if (mode == VIEW_ALTER &&

        fill_defined_view_parts(thd, view))

    {

      res= TRUE;

      goto err;

    }

    sp_cache_invalidate();

  }



  if (!lex->definer)

  {

sql/sql_yacc.yy

+3 −3
Original line number Diff line number Diff line
@@ -8997,11 +8997,11 @@ view_algorithm_opt: 


view_suid:

	/* empty */

	{ Lex->create_view_suid= TRUE; }

	{ Lex->create_view_suid= VIEW_SUID_DEFAULT; }

	| SQL_SYM SECURITY_SYM DEFINER_SYM

	{ Lex->create_view_suid= TRUE; }

	{ Lex->create_view_suid= VIEW_SUID_DEFINER; }

	| SQL_SYM SECURITY_SYM INVOKER_SYM

	{ Lex->create_view_suid= FALSE; }

	{ Lex->create_view_suid= VIEW_SUID_INVOKER; }

	;



view_tail: