Commit d5c7d850 authored by unknown's avatar unknown
Browse files

Fix segmentation fault on incorrect configuration. 

Starting ndb_mgmd on a host which isn't in the configuration file as the ndb_mgmd 
(e.g. the ip address is different) would have ndb_mgmd segfault.

There was a check in the code, but it was (potentially) trying to dereference null


ndb/src/mgmsrv/MgmtSrvr.cpp:
  Don't try and print client_addr->sin_addr if client_addr is null
parent 80b3339f

ndb/src/mgmsrv/MgmtSrvr.cpp

+3 −2
Original line number Diff line number Diff line
@@ -2292,8 +2292,9 @@ MgmtSrvr::alloc_node_id(NodeId * nodeId, 
      if (found_matching_type)

	if (found_free_node)

	  error_string.appfmt("Connection done from wrong host ip %s.",

			      (client_addr)?

			        inet_ntoa(((struct sockaddr_in *)

					 (client_addr))->sin_addr));

					 (client_addr))->sin_addr):"");

	else

	  error_string.appfmt("No free node id found for %s.",

			      type_string.c_str());