Commit d9e44dc7 authored by unknown's avatar unknown
Browse files

Merge bk-internal.mysql.com:/home/bk/mysql-4.1 

into  mysql.com:/opt/local/work/mysql-4.1-root
parents 86ae5158 cb7a5b53

mysql-test/r/ps.result

+16 −0
Original line number Diff line number Diff line
@@ -660,3 +660,19 @@ lily 
river

drop table t1;

deallocate prepare stmt;

create table t1 (a int);

prepare stmt from "select ??";

ERROR 42000: You have an error in your SQL syntax; check the manual that corresponds to your MySQL server version for the right syntax to use near '?' at line 1

prepare stmt from "select ?FROM t1";

ERROR 42000: You have an error in your SQL syntax; check the manual that corresponds to your MySQL server version for the right syntax to use near '?FROM t1' at line 1

prepare stmt from "select FROM t1 WHERE?=1";

ERROR 42000: You have an error in your SQL syntax; check the manual that corresponds to your MySQL server version for the right syntax to use near 'FROM t1 WHERE?=1' at line 1

prepare stmt from "update t1 set a=a+?WHERE 1";

ERROR 42000: You have an error in your SQL syntax; check the manual that corresponds to your MySQL server version for the right syntax to use near '?WHERE 1' at line 1

select ?;

ERROR 42000: You have an error in your SQL syntax; check the manual that corresponds to your MySQL server version for the right syntax to use near '?' at line 1

select ??;

ERROR 42000: You have an error in your SQL syntax; check the manual that corresponds to your MySQL server version for the right syntax to use near '??' at line 1

select ? from t1;

ERROR 42000: You have an error in your SQL syntax; check the manual that corresponds to your MySQL server version for the right syntax to use near '? from t1' at line 1

drop table t1;

mysql-test/t/ps.test

+22 −0
Original line number Diff line number Diff line
@@ -679,3 +679,25 @@ execute stmt using @param1; 
select utext from t1 where utext like '%%';

drop table t1;

deallocate prepare stmt;

#

# Bug#11299 "prepared statement makes wrong SQL syntax in binlog which stops

# replication": check that errouneous queries with placeholders are not

# allowed

#

create table t1 (a int);

--error 1064

prepare stmt from "select ??";

--error 1064

prepare stmt from "select ?FROM t1";

--error 1064

prepare stmt from "select FROM t1 WHERE?=1";

--error 1064

prepare stmt from "update t1 set a=a+?WHERE 1";

--error 1064

select ?;

--error 1064

select ??;

--error 1064

select ? from t1;

drop table t1;

#

sql/sql_lex.cc

+9 −0
Original line number Diff line number Diff line
@@ -554,6 +554,15 @@ int yylex(void *arg, void *yythd) 
	lex->next_state= MY_LEX_START;	// Allow signed numbers

      if (c == ',')

	lex->tok_start=lex->ptr;	// Let tok_start point at next item

      /*

        Check for a placeholder: it should not precede a possible identifier

        because of binlogging: when a placeholder is replaced with

        its value in a query for the binlog, the query must stay

        grammatically correct.

      */

      else if (c == '?' && ((THD*) yythd)->command == COM_PREPARE &&

               !ident_map[cs, yyPeek()])

        return(PARAM_MARKER);

      return((int) c);



    case MY_LEX_IDENT_OR_NCHAR:

sql/sql_yacc.yy

+6 −13
Original line number Diff line number Diff line
@@ -528,6 +528,7 @@ bool my_yyoverflow(short **a, YYSTYPE **b, ulong *yystacksize); 
%token	NOW_SYM

%token	OLD_PASSWORD

%token	PASSWORD

%token  PARAM_MARKER

%token	POINTFROMTEXT

%token	POINT_SYM

%token	POLYFROMTEXT
@@ -4857,12 +4858,10 @@ text_string: 
	;



param_marker:

        '?'

        PARAM_MARKER

        {

          THD *thd=YYTHD;

	  LEX *lex= thd->lex;

          if (thd->command == COM_PREPARE)

          {

          Item_param *item= new Item_param((uint) (lex->tok_start -

                                                   (uchar *) thd->query));

          if (!($$= item) || lex->param_list.push_back(item))
@@ -4871,12 +4870,6 @@ param_marker: 
            YYABORT;

          }

        }

          else

          {

            yyerror(ER(ER_SYNTAX_ERROR));

            YYABORT;

          }

        }

	;



signed_literal: