Commit da29c528 authored by Mattias Jonsson's avatar Mattias Jonsson
Browse files

Bug#35161: --myisam-recover does not work for partitioned MyISAM tables 

Problem was that auto_repair, is_crashed and check_and_repair was not
implemented in ha_partition.

Solution, implemented them as loop over all partitions for is_crashed and
check_and_repair, and using the first partition for auto_repair.

(Recommit after fixing review comments)
parent 78cca2d5

mysql-test/lib/mtr_report.pl

+4 −1
Original line number Diff line number Diff line
@@ -402,7 +402,10 @@ sub mtr_report_stats ($) { 
		 )) or



                # Test case for Bug#31590 produces the following error:

                /Out of sort memory; increase server sort buffer size/

                /Out of sort memory; increase server sort buffer size/ or



                # Bug#35161, test of auto repair --myisam-recover

                /able.*_will_crash/

		)

            {

              next;                       # Skip these lines

mysql-test/std_data/corrupt_t1#P#p1.MYI

0 → 100644
+1 KiB

File added.

Preview suppressed by a .gitattributes entry or the file's encoding is unsupported.

View file

mysql-test/std_data/corrupt_t1.MYI

0 → 100644
+1 KiB

File added.

Preview suppressed by a .gitattributes entry or the file's encoding is unsupported.

View file

mysql-test/suite/parts/r/partition_repair_myisam.result

0 → 100644
+56 −0
Original line number Diff line number Diff line 
CREATE TABLE t1_will_crash (a INT, KEY (a)) ENGINE=MyISAM;

INSERT INTO t1_will_crash VALUES (1), (2), (3), (4), (5), (6), (7), (8), (9), (10), (11);

FLUSH TABLES;

# replacing t1.MYI with a corrupt + unclosed one created by doing:

# 'create table t1 (a int key(a))' head -c1024 t1.MYI > corrupt_t1.MYI 

SELECT * FROM t1_will_crash;

a

1

2

3

4

5

6

7

8

9

10

11

Warnings:

Error	145	Table './test/t1_will_crash' is marked as crashed and should be repaired

Error	1194	Table 't1_will_crash' is marked as crashed and should be repaired

Error	1034	1 client is using or hasn't closed the table properly

Error	1034	Size of indexfile is: 1024        Should be: 2048

Error	1034	Size of datafile is: 77       Should be: 7

Error	1034	Number of rows changed from 1 to 11

DROP TABLE t1_will_crash;

CREATE TABLE t1_will_crash (a INT, KEY (a))

ENGINE=MyISAM

PARTITION BY HASH(a)

PARTITIONS 3;

INSERT INTO t1_will_crash VALUES (1), (2), (3), (4), (5), (6), (7), (8), (9), (10), (11);

FLUSH TABLES;

# replacing t1#P#p1.MYI with a corrupt + unclosed one created by doing:

# 'create table t1 (a int key(a)) partition by hash (a) partitions 3'

# head -c1024 t1#P#p1.MYI > corrupt_t1#P#p1.MYI 

SELECT * FROM t1_will_crash;

a

1

2

3

4

5

6

7

8

9

10

11

Warnings:

Error	145	Table './test/t1_will_crash#P#p1' is marked as crashed and should be repaired

Error	1194	Table 't1_will_crash' is marked as crashed and should be repaired

Error	1034	1 client is using or hasn't closed the table properly

Error	1034	Size of indexfile is: 1024        Should be: 2048

Error	1034	Size of datafile is: 28       Should be: 7

Error	1034	Number of rows changed from 1 to 4

DROP TABLE t1_will_crash;

mysql-test/suite/parts/t/partition_repair_myisam-master.opt

0 → 100644
+1 −0
Original line number Diff line number Diff line 
--myisam-recover