Commit dc4d8ec6 authored by unknown's avatar unknown
Browse files

ndb - bug#26481 - fix of bug fix 

  Make sure GCP_SAVEREQ is not allowed before START_RECCONF has been sent...START_RECREQ is not enough



storage/ndb/src/kernel/blocks/dblqh/DblqhMain.cpp:
  Make sure GCP_SAVEREQ is not allowed before START_RECCONF has been sent...
  START_RECREQ is not enough
parent d8a5d43c

storage/ndb/src/kernel/blocks/dblqh/DblqhMain.cpp

+7 −4
Original line number Diff line number Diff line
@@ -440,6 +440,7 @@ void Dblqh::execCONTINUEB(Signal* signal) 
    else

    {

      jam();

      cstartRecReq = 2;

      ndbrequire(c_redo_complete_fragments.isEmpty());

      StartRecConf * conf = (StartRecConf*)signal->getDataPtrSend();

      conf->startingNodeId = getOwnNodeId();
@@ -11893,7 +11894,7 @@ void Dblqh::execGCP_SAVEREQ(Signal* signal) 
    return;

  }









  if (getNodeState().getNodeRestartInProgress() && cstartRecReq == ZFALSE)









  if (getNodeState().getNodeRestartInProgress() && cstartRecReq < 2)









  {









    GCPSaveRef * const saveRef = (GCPSaveRef*)&signal->theData[0];









    saveRef->dihPtr = dihPtr;








@@ -13978,7 +13979,7 @@ void Dblqh::execRESTORE_LCP_CONF(Signal* signal)







    return;









  }

















  if (c_lcp_restoring_fragments.isEmpty() && cstartRecReq == ZTRUE)









  if (c_lcp_restoring_fragments.isEmpty() && cstartRecReq == 1)









  {









    jam();









    /* ----------------------------------------------------------------








@@ -14019,7 +14020,7 @@ void Dblqh::execSTART_RECREQ(Signal* signal)







  ndbrequire(req->receivingNodeId == cownNodeid);

















  cnewestCompletedGci = cnewestGci;









  cstartRecReq = ZTRUE;









  cstartRecReq = 1;









  for (logPartPtr.i = 0; logPartPtr.i < 4; logPartPtr.i++) {









    ptrAss(logPartPtr, logPartRecord);









    logPartPtr.p->logPartNewestCompletedGCI = cnewestCompletedGci;








@@ -14033,6 +14034,7 @@ void Dblqh::execSTART_RECREQ(Signal* signal)







   *------------------------------------------------------------------------ */









  if(cstartType == NodeState::ST_INITIAL_NODE_RESTART){









    jam();









    cstartRecReq = 2;









    StartRecConf * conf = (StartRecConf*)signal->getDataPtrSend();









    conf->startingNodeId = getOwnNodeId();









    sendSignal(cmasterDihBlockref, GSN_START_RECCONF, signal, 








@@ -15856,6 +15858,7 @@ void Dblqh::srFourthComp(Signal* signal)







	return;









      }









    }









    cstartRecReq = 2;









    StartRecConf * conf = (StartRecConf*)signal->getDataPtrSend();









    conf->startingNodeId = getOwnNodeId();









    sendSignal(cmasterDihBlockref, GSN_START_RECCONF, signal, 








@@ -16724,7 +16727,7 @@ void Dblqh::initialiseRecordsLab(Signal* signal, Uint32 data,







    cnoActiveCopy = 0;









    ccurrentGcprec = RNIL;









    caddNodeState = ZFALSE;









    cstartRecReq = ZFALSE;









    cstartRecReq = 0;









    cnewestGci = 0;









    cnewestCompletedGci = 0;









    crestartOldestGci = 0;