Commit e10d8144 authored by unknown's avatar unknown
Browse files

Moved some old test and added a new test to only be run with mysql-test-run --big 

Fixed warnings by valgrind for sum_distinct.test
Enable buffered-record-reads after filesort for InnoDB tables with short primary key
Enabled sort-with-data for MyISAM temporary files


BitKeeper/etc/ignore:
  added tools/mysqltestmanager
client/mysqltest.c:
  Ensure that BIG_TEST is always set to 0 or 1
  Fix the 'eval' also honors 'require'
mysql-test/mysql-test-run.sh:
  Enlarge InnoDB table space for --big tests
mysql-test/r/heap.result:
  Fix after adding more optimzation for filsort
mysql-test/r/sum_distinct.result:
  Move 'slow' part of test to sum_distinct-big.test
mysql-test/t/heap.test:
  Ensure that results are indpendent of optimizer
mysql-test/t/sum_distinct.test:
  Move 'slow' part of test to sum_distinct-big.test
sql/filesort.cc:
  Use 'sort with data' also on temporary files and with INSERT ... SELECT
sql/ha_innodb.h:
  Remove HA_FAST_KEY_READ to enable buffered-record-reads after filesort
sql/handler.h:
  More comments
sql/mysql_priv.h:
  A bit smaller limit for cache for buffered-records-read (after testing)
sql/records.cc:
  Don't use buffered-record-reads if ref_length > MAX_REFLENGTH
  Fixed warning from valgrind in 'sum_distinct'
sql/sql_select.cc:
  Ensure that tempory tables has query_id set for all fields
  (Required for sort-with-data to work on temp files)
parent 99c0dd3b

.bzrignore

+1 −0
Original line number Diff line number Diff line
@@ -1109,3 +1109,4 @@ vio/viotest-ssl 
VC++Files/client/mysql_amd64.dsp

client/mysqltestmanager-pwgen

client/mysqltestmanagerc

tools/mysqltestmanager

client/mysqltest.c

+9 −2
Original line number Diff line number Diff line
@@ -645,6 +645,7 @@ int dyn_string_cmp(DYNAMIC_STRING* ds, const char* fname) 
  {

    DBUG_PRINT("info",("Size differs:  result size: %u  file size: %u",

		       ds->length, stat_info.st_size));

    DBUG_PRINT("info",("result: '%s'", ds->str));

    DBUG_RETURN(2);

  }

  if (!(tmp = (char*) my_malloc(stat_info.st_size + 1, MYF(MY_WME))))
@@ -3623,8 +3624,8 @@ static void init_var_hash(MYSQL *mysql) 
  if (hash_init(&var_hash, charset_info, 

                1024, 0, 0, get_var_key, var_free, MYF(0)))

    die("Variable hash initialization failed");

  if (opt_big_test)

    my_hash_insert(&var_hash, (byte*) var_init(0,"BIG_TEST", 0, "1",0));

  my_hash_insert(&var_hash, (byte*) var_init(0,"BIG_TEST", 0,

                                             (opt_big_test) ? "1" : "0", 0));

  v= var_init(0,"MAX_TABLES", 0, (sizeof(ulong) == 4) ? "31" : "62",0);

  my_hash_insert(&var_hash, (byte*) v);

  v= var_init(0,"SERVER_VERSION", 0, mysql_get_server_info(mysql), 0);
@@ -3793,6 +3794,12 @@ int main(int argc, char **argv) 
	if (q->query == q->query_buf)

	  q->query += q->first_word_len + 1;

	display_result_vertically= (q->type==Q_QUERY_VERTICAL);

	if (save_file[0])

	{

	  strmov(q->record_file,save_file);

	  q->require_file=require_file;

	  save_file[0]=0;

	}

	error|= run_query(&cur_con->mysql, q, QUERY_REAP|QUERY_SEND);

	display_result_vertically= old_display_result_vertically;

	break;

mysql-test/include/big_test.inc

0 → 100644
+4 −0
Original line number Diff line number Diff line 
--require r/big_test.require

disable_query_log;

eval select $BIG_TEST as using_big_test;

enable_query_log;

mysql-test/mysql-test-run.sh

+2 −2
Original line number Diff line number Diff line
@@ -1179,7 +1179,7 @@ start_master() 
          --default-character-set=$CHARACTER_SET \

          --tmpdir=$MYSQL_TMP_DIR \

          --language=$LANGUAGE \

          --innodb_data_file_path=ibdata1:50M \

          --innodb_data_file_path=ibdata1:128M:autoextend \

	  --open-files-limit=1024 \

	   $MASTER_40_ARGS \

           $SMALL_SERVER \
@@ -1200,7 +1200,7 @@ start_master() 
          $USE_NDBCLUSTER \

          --tmpdir=$MYSQL_TMP_DIR \

          --language=$LANGUAGE \

          --innodb_data_file_path=ibdata1:50M \

          --innodb_data_file_path=ibdata1:128M:autoextend \

	   $MASTER_40_ARGS \

           $SMALL_SERVER \

           $EXTRA_MASTER_OPT $EXTRA_MASTER_MYSQLD_OPT \

mysql-test/r/heap.result

+30 −30
Original line number Diff line number Diff line
@@ -436,8 +436,8 @@ f 10 
g	10

h	10

i	10

select sql_big_result v,count(t) from t1 group by v limit 10;

v	count(t)

select sql_big_result trim(v),count(t) from t1 group by v limit 10;

trim(v)	count(t)

a	1

a	10

b	10
@@ -448,8 +448,8 @@ f 10 
g	10

h	10

i	10

select sql_big_result v,count(c) from t1 group by v limit 10;

v	count(c)

select sql_big_result trim(v),count(c) from t1 group by v limit 10;

trim(v)	count(c)

a	1

a	10

b	10
@@ -520,8 +520,8 @@ f 10 
g	10

h	10

i	10

select sql_big_result t,count(t) from t1 group by t limit 10;

t	count(t)

select sql_big_result trim(t),count(t) from t1 group by t limit 10;

trim(t)	count(t)

a	1

a	10

b	10