Commit e17d7bce authored by svoj@mysql.com/april.(none)'s avatar svoj@mysql.com/april.(none)
Browse files

BUG#23404 - ROW_FORMAT=FIXED option is lost is an index is added to the 

            table

ROW_FORMAT option is lost during CREATE/DROP INDEX.

This fix forces CREATE/DROP INDEX to retain ROW_FORMAT by instructing
mysql_alter_table() that ROW_FORMAT is not used during creating/dropping
indexes.
parent ab70ed5e

mysql-test/r/alter_table.result

+15 −0
Original line number Diff line number Diff line
@@ -543,3 +543,18 @@ ERROR 3D000: No database selected 
alter table test.t1 rename test.t1;

use test;

drop table t1;

CREATE TABLE t1(a INT) ROW_FORMAT=FIXED;

CREATE INDEX i1 ON t1(a);

SHOW CREATE TABLE t1;

Table	Create Table

t1	CREATE TABLE `t1` (

  `a` int(11) default NULL,

  KEY `i1` (`a`)

) ENGINE=MyISAM DEFAULT CHARSET=latin1 ROW_FORMAT=FIXED

DROP INDEX i1 ON t1;

SHOW CREATE TABLE t1;

Table	Create Table

t1	CREATE TABLE `t1` (

  `a` int(11) default NULL

) ENGINE=MyISAM DEFAULT CHARSET=latin1 ROW_FORMAT=FIXED

DROP TABLE t1;

mysql-test/t/alter_table.test

+11 −0
Original line number Diff line number Diff line
@@ -392,4 +392,15 @@ alter table test.t1 rename test.t1; 
use test;

drop table t1;



#

# BUG#23404 - ROW_FORMAT=FIXED option is lost is an index is added to the

# table

#

CREATE TABLE t1(a INT) ROW_FORMAT=FIXED;

CREATE INDEX i1 ON t1(a);

SHOW CREATE TABLE t1;

DROP INDEX i1 ON t1;

SHOW CREATE TABLE t1;

DROP TABLE t1;



# End of 4.1 tests

sql/sql_parse.cc

+2 −0
Original line number Diff line number Diff line
@@ -5481,6 +5481,7 @@ int mysql_create_index(THD *thd, TABLE_LIST *table_list, List<Key> &keys) 
  bzero((char*) &create_info,sizeof(create_info));

  create_info.db_type=DB_TYPE_DEFAULT;

  create_info.default_table_charset= thd->variables.collation_database;

  create_info.row_type= ROW_TYPE_NOT_USED;

  DBUG_RETURN(mysql_alter_table(thd,table_list->db,table_list->real_name,

				&create_info, table_list,

				fields, keys, 0, (ORDER*)0,
@@ -5497,6 +5498,7 @@ int mysql_drop_index(THD *thd, TABLE_LIST *table_list, ALTER_INFO *alter_info) 
  bzero((char*) &create_info,sizeof(create_info));

  create_info.db_type=DB_TYPE_DEFAULT;

  create_info.default_table_charset= thd->variables.collation_database;

  create_info.row_type= ROW_TYPE_NOT_USED;

  alter_info->clear();

  alter_info->flags= ALTER_DROP_INDEX;

  alter_info->is_simple= 0;