Commit e1b9e55a authored by msvensson@pilot.(none)'s avatar msvensson@pilot.(none)
Browse files

Bug#30593 No cipher list returned for "SHOW STATUS LIKE 'Ssl_cipher_list'" 

 - Move increment of "i" to "increment section" of for loop
 - Protect against writing after end of "buff"(backport from 5.1)
parent f7738637

sql/sql_show.cc

+3 −2
Original line number Diff line number Diff line
@@ -1739,12 +1739,13 @@ static bool show_status_array(THD *thd, const char *wild, 
          if (thd->net.vio->ssl_arg)

          {

            char *to= buff;

            for (int i=0 ; i++ ;)

            char *buff_end= buff + sizeof(buff);

            for (int i= 0; to < buff_end; i++)

            {

              const char *p= SSL_get_cipher_list((SSL*) thd->net.vio->ssl_arg,i);

              if (p == NULL)

                break;

              to= strmov(to, p);

              to= strnmov(to, p, buff_end-to-1);

              *to++= ':';

            }

            if (to != buff)