Commit ec00a455 authored by unknown's avatar unknown
Browse files

Additions for --add-drop-database 


client/client_priv.h:
  Adding option for drop database
client/mysqldump.c:
  Work for adding of --add-drop-database
mysql-test/r/mysqldump.result:
  New test results for --add-drop-databases
mysql-test/t/mysqldump.test:
  Tests for --add-drop-databases
parent f4a584f5

client/client_priv.h

+1 −1
Original line number Diff line number Diff line
@@ -49,5 +49,5 @@ enum options_client 
#ifdef HAVE_NDBCLUSTER_DB

  ,OPT_NDBCLUSTER,OPT_NDB_CONNECTSTRING

#endif

  ,OPT_IGNORE_TABLE,OPT_INSERT_IGNORE

  ,OPT_IGNORE_TABLE,OPT_INSERT_IGNORE,OPT_DROP_DATABASE

};

client/mysqldump.c

+15 −4
Original line number Diff line number Diff line
@@ -85,7 +85,7 @@ static my_bool verbose=0,tFlag=0,dFlag=0,quick= 1, extended_insert= 1, 
		opt_delete_master_logs=0, tty_password=0,

		opt_single_transaction=0, opt_comments= 0, opt_compact= 0,

		opt_hex_blob=0, opt_order_by_primary=0, opt_ignore=0,

                opt_complete_insert= 0;

                opt_complete_insert= 0, opt_drop_database= 0;

static ulong opt_max_allowed_packet, opt_net_buffer_length;

static MYSQL mysql_connection,*sock=0;

static my_bool insert_pat_inited=0;
@@ -159,6 +159,9 @@ static struct my_option my_long_options[] = 
   "Dump all the databases. This will be same as --databases with all databases selected.",

   (gptr*) &opt_alldbs, (gptr*) &opt_alldbs, 0, GET_BOOL, NO_ARG, 0, 0, 0, 0,

   0, 0},

  {"add-drop-database", OPT_DROP_DATABASE, "Add a 'DROP DATABASE' before each create.",

   (gptr*) &opt_drop_database, (gptr*) &opt_drop_database, 0, GET_BOOL, NO_ARG, 0, 0, 0, 0, 0,

   0},

  {"add-drop-table", OPT_DROP, "Add a 'drop table' before each create.",

   (gptr*) &opt_drop, (gptr*) &opt_drop, 0, GET_BOOL, NO_ARG, 1, 0, 0, 0, 0,

   0},
@@ -1119,9 +1122,9 @@ static uint getTableStructure(char *table, char* db) 
  else

    dynstr_set(&insert_pat, "");



  insert_option= (opt_delayed && opt_ignore) ? " DELAYED IGNORE " : 

  insert_option= ((opt_delayed && opt_ignore) ? " DELAYED IGNORE " : 

                  opt_delayed ? " DELAYED " :

    opt_ignore ? " IGNORE " : "";

                  opt_ignore ? " IGNORE " : "");



  if (verbose)

    fprintf(stderr, "-- Retrieving table structure for table %s...\n", table);
@@ -2043,12 +2046,20 @@ static int init_dumping(char *database) 
        if (mysql_query(sock, qbuf) || !(dbinfo = mysql_store_result(sock)))

        {

          /* Old server version, dump generic CREATE DATABASE */

          if (opt_drop_database)

            fprintf(md_result_file,

                    "\n/*!40000 DROP DATABASE IF EXISTS %s;*/\n",

                    qdatabase);

	  fprintf(md_result_file,

		  "\nCREATE DATABASE /*!32312 IF NOT EXISTS*/ %s;\n",

		  qdatabase);

	}

	else

        {

          if (opt_drop_database)

            fprintf(md_result_file,

                    "\n/*!40000 DROP DATABASE IF EXISTS %s*/;\n",

                    qdatabase);

	  row = mysql_fetch_row(dbinfo);

	  if (row[1])

	  {

mysql-test/r/mysqldump.result

+38 −0
Original line number Diff line number Diff line
@@ -1311,3 +1311,41 @@ UNLOCK TABLES; 
/*!40111 SET SQL_NOTES=@OLD_SQL_NOTES */;



drop table t1;

CREATE TABLE t1 (a int);

INSERT INTO t1 VALUES (1),(2),(3);



/*!40101 SET @OLD_CHARACTER_SET_CLIENT=@@CHARACTER_SET_CLIENT */;

/*!40101 SET @OLD_CHARACTER_SET_RESULTS=@@CHARACTER_SET_RESULTS */;

/*!40101 SET @OLD_COLLATION_CONNECTION=@@COLLATION_CONNECTION */;

/*!40101 SET NAMES utf8 */;

/*!40014 SET @OLD_UNIQUE_CHECKS=@@UNIQUE_CHECKS, UNIQUE_CHECKS=0 */;

/*!40014 SET @OLD_FOREIGN_KEY_CHECKS=@@FOREIGN_KEY_CHECKS, FOREIGN_KEY_CHECKS=0 */;

/*!40101 SET @OLD_SQL_MODE=@@SQL_MODE, SQL_MODE='NO_AUTO_VALUE_ON_ZERO' */;

/*!40111 SET @OLD_SQL_NOTES=@@SQL_NOTES, SQL_NOTES=0 */;



/*!40000 DROP DATABASE IF EXISTS `test`*/;



CREATE DATABASE /*!32312 IF NOT EXISTS*/ `test` /*!40100 DEFAULT CHARACTER SET latin1 */;



USE `test`;

DROP TABLE IF EXISTS `t1`;

CREATE TABLE `t1` (

  `a` int(11) default NULL

) ENGINE=MyISAM DEFAULT CHARSET=latin1;





/*!40000 ALTER TABLE `t1` DISABLE KEYS */;

LOCK TABLES `t1` WRITE;

INSERT INTO `t1` VALUES (1),(2),(3);

UNLOCK TABLES;

/*!40000 ALTER TABLE `t1` ENABLE KEYS */;



/*!40101 SET SQL_MODE=@OLD_SQL_MODE */;

/*!40014 SET FOREIGN_KEY_CHECKS=@OLD_FOREIGN_KEY_CHECKS */;

/*!40014 SET UNIQUE_CHECKS=@OLD_UNIQUE_CHECKS */;

/*!40101 SET CHARACTER_SET_CLIENT=@OLD_CHARACTER_SET_CLIENT */;

/*!40101 SET CHARACTER_SET_RESULTS=@OLD_CHARACTER_SET_RESULTS */;

/*!40101 SET COLLATION_CONNECTION=@OLD_COLLATION_CONNECTION */;

/*!40111 SET SQL_NOTES=@OLD_SQL_NOTES */;



DROP TABLE t1;

mysql-test/t/mysqldump.test

+9 −0
Original line number Diff line number Diff line
@@ -534,3 +534,12 @@ create table t1 ( 
insert into t1 (F_8d3bba7425e7c98c50f52ca1b52d3735) values (1);

--exec $MYSQL_DUMP --skip-comments -c test

drop table t1;



#

# Test for --add-drop-database

#



CREATE TABLE t1 (a int);

INSERT INTO t1 VALUES (1),(2),(3);

--exec $MYSQL_DUMP --add-drop-database --skip-comments --databases test

DROP TABLE t1;