Commit f0e0e5c5 authored by unknown's avatar unknown
Browse files

Bug#17081 LOAD DATA INFILE" may not load all the data 

Bug #17154  	load data infile hangs when duplicate key encountered


mysql-test/r/ndb_load.result:
  New BitKeeper file ``mysql-test/r/ndb_load.result''
mysql-test/t/ndb_load.test:
  New BitKeeper file ``mysql-test/t/ndb_load.test''
parent 3449ca1a

mysql-test/r/ndb_load.result

0 → 100644
+80 −0
Original line number Diff line number Diff line 
DROP TABLE IF EXISTS t1;

CREATE TABLE t1 (word CHAR(20) NOT NULL PRIMARY KEY) ENGINE=NDB;

LOAD DATA INFILE '../../std_data/words.dat' INTO TABLE t1 ;

ERROR 23000: Can't write; duplicate key in table 't1'

DROP TABLE t1;

CREATE TABLE t1 (word CHAR(20) NOT NULL) ENGINE=NDB;

LOAD DATA INFILE '../../std_data/words.dat' INTO TABLE t1 ;

SELECT * FROM t1 ORDER BY word;

word

Aarhus

Aarhus

Aaron

Aaron

Ababa

Ababa

aback

aback

abaft

abaft

abandon

abandon

abandoned

abandoned

abandoning

abandoning

abandonment

abandonment

abandons

abandons

abase

abased

abasement

abasements

abases

abash

abashed

abashes

abashing

abasing

abate

abated

abatement

abatements

abater

abates

abating

Abba

abbe

abbey

abbeys

abbot

abbots

Abbott

abbreviate

abbreviated

abbreviates

abbreviating

abbreviation

abbreviations

Abby

abdomen

abdomens

abdominal

abduct

abducted

abduction

abductions

abductor

abductors

abducts

Abe

abed

Abel

Abelian

Abelson

Aberdeen

Abernathy

aberrant

aberration

DROP TABLE t1;

mysql-test/t/ndb_load.test

0 → 100644
+24 −0
Original line number Diff line number Diff line 
-- source include/have_ndb.inc

-- source include/not_embedded.inc



--disable_warnings

DROP TABLE IF EXISTS t1;

--enable_warnings



#

# Basic test for different types of loading data

#



# should give duplicate key

CREATE TABLE t1 (word CHAR(20) NOT NULL PRIMARY KEY) ENGINE=NDB;

--error 1022

LOAD DATA INFILE '../../std_data/words.dat' INTO TABLE t1 ;

DROP TABLE t1;



# now without a primary key we should be ok

CREATE TABLE t1 (word CHAR(20) NOT NULL) ENGINE=NDB;

LOAD DATA INFILE '../../std_data/words.dat' INTO TABLE t1 ;

SELECT * FROM t1 ORDER BY word;

DROP TABLE t1;



# End of 4.1 tests

sql/ha_ndbcluster.cc

+23 −8
Original line number Diff line number Diff line
@@ -3446,10 +3446,27 @@ int ha_ndbcluster::end_bulk_insert() 
                        "rows_inserted:%d, bulk_insert_rows: %d", 

                        (int) m_rows_inserted, (int) m_bulk_insert_rows)); 

    m_bulk_insert_not_flushed= FALSE;

    if (execute_no_commit(this,trans) != 0) {

    if (m_transaction_on)

    {

      if (execute_no_commit(this, trans) != 0)

      {

        no_uncommitted_rows_execute_failure();

        my_errno= error= ndb_err(trans);

      }

    }

    else

    {

      if (execute_commit(this, trans) != 0)

      {

        no_uncommitted_rows_execute_failure();

        my_errno= error= ndb_err(trans);

      }

      else

      {

        int res= trans->restart();

        DBUG_ASSERT(res == 0);

      }

    }

  }



  m_rows_inserted= (ha_rows) 0;
@@ -3605,7 +3622,6 @@ int ha_ndbcluster::external_lock(THD *thd, int lock_type) 
          ERR_RETURN(ndb->getNdbError());

        no_uncommitted_rows_reset(thd);

        thd_ndb->stmt= trans;

        if (m_transaction_on)

        trans_register_ha(thd, FALSE, &ndbcluster_hton);

      } 

      else
@@ -3621,7 +3637,6 @@ int ha_ndbcluster::external_lock(THD *thd, int lock_type) 
            ERR_RETURN(ndb->getNdbError());

          no_uncommitted_rows_reset(thd);

          thd_ndb->all= trans; 

          if (m_transaction_on)

          trans_register_ha(thd, TRUE, &ndbcluster_hton);



          /*
@@ -6194,7 +6209,7 @@ bool ha_ndbcluster::low_byte_first() const 
}

bool ha_ndbcluster::has_transactions()

{

  return m_transaction_on;

  return TRUE;

}

const char* ha_ndbcluster::index_type(uint key_number)

{

sql/sql_load.cc

+5 −2
Original line number Diff line number Diff line
@@ -384,8 +384,11 @@ bool mysql_load(THD *thd,sql_exchange *ex,TABLE_LIST *table_list, 
      error= read_sep_field(thd, info, table_list, fields_vars,

                            set_fields, set_values, read_info,

			    *enclosed, skip_lines, ignore);

    if (table->file->end_bulk_insert())

      error=1;					/* purecov: inspected */

    if (table->file->end_bulk_insert() && !error)

    {

      table->file->print_error(my_errno, MYF(0));

      error= 1;

    }

    table->file->extra(HA_EXTRA_NO_IGNORE_DUP_KEY);

    table->next_number_field=0;

  }