Commit f1fde80a authored by unknown's avatar unknown
Browse files

ndb - 

  fix all valgrind warnings in t/ndb_dd (except replication related)


sql/ha_ndbcluster.cc:
  Fix memleak
storage/ndb/include/kernel/signaldata/DictTabInfo.hpp:
  Fix valgrind warning
storage/ndb/include/kernel/signaldata/DropFilegroup.hpp:
  Fix valgrind warning
storage/ndb/src/common/debugger/signaldata/DictTabInfo.cpp:
  Fix valgrind warning
storage/ndb/src/kernel/blocks/dbdict/Dbdict.cpp:
  Fix valgrind warning
storage/ndb/src/kernel/blocks/dbdict/Dbdict.hpp:
  Fix valgrind warning
storage/ndb/src/ndbapi/NdbDictionaryImpl.cpp:
  Fix valgrind warning
storage/ndb/src/ndbapi/ndberror.c:
  Fix valgrind warning
parent d94f4a42

sql/ha_ndbcluster.cc

+5 −4
Original line number Diff line number Diff line
@@ -5733,7 +5733,6 @@ int ndbcluster_find_all_files(THD *thd) 
  DBUG_ENTER("ndbcluster_find_all_files");

  Ndb* ndb;

  char key[FN_REFLEN];

  NdbDictionary::Dictionary::List list;



  if (!(ndb= check_ndb_in_thd(thd)))

    DBUG_RETURN(HA_ERR_NO_CONNECTION);
@@ -5743,6 +5742,7 @@ int ndbcluster_find_all_files(THD *thd) 
  int unhandled, retries= 5;

  do

  {

    NdbDictionary::Dictionary::List list;

    if (dict->listObjects(list, NdbDictionary::Object::UserTable) != 0)

      ERR_RETURN(dict->getNdbError());

    unhandled= 0;
@@ -10029,14 +10029,15 @@ static int ndbcluster_fill_files_table(THD *thd, TABLE_LIST *tables, COND *cond) 
    }

  }



  dict->listObjects(dflist, NdbDictionary::Object::Undofile);

  NdbDictionary::Dictionary::List uflist;

  dict->listObjects(uflist, NdbDictionary::Object::Undofile);

  ndberr= dict->getNdbError();

  if (ndberr.classification != NdbError::NoError)

    ERR_RETURN(ndberr);



  for (i= 0; i < dflist.count; i++)

  for (i= 0; i < uflist.count; i++)

  {

    NdbDictionary::Dictionary::List::Element& elt= dflist.elements[i];

    NdbDictionary::Dictionary::List::Element& elt= uflist.elements[i];

    Ndb_cluster_connection_node_iter iter;

    unsigned id;

storage/ndb/include/kernel/signaldata/DictTabInfo.hpp

+5 −4
Original line number Diff line number Diff line
@@ -586,7 +586,8 @@ public: 
  enum Unimplemented

  {

    ScanOptimised      = 15, //Default updateOptimised

    AttributeGroup     = 1012 //Default 0

    AttributeGroup     = 1012, //Default 0

    FileNo             = 102

  };

};
@@ -618,13 +619,13 @@ struct DictFilegroupInfo { 
     */

    FileName          = 100,

    FileType          = 101,

    FileId            = 102,

    FileNo            = 103, // Per Filegroup

    FileId            = 103,

    FileFGroupId      = 104,

    FileFGroupVersion = 105,

    FileSizeHi        = 106,

    FileSizeLo        = 107,

    FileFreeExtents   = 108,

    FileVersion       = 109,

    FileEnd           = 199, //    



    /**
@@ -696,8 +697,8 @@ struct DictFilegroupInfo { 
  struct File {

    char FileName[PATH_MAX];

    Uint32 FileType;

    Uint32 FileNo;

    Uint32 FileId;

    Uint32 FileVersion;

    Uint32 FilegroupId;

    Uint32 FilegroupVersion;

    Uint32 FileSizeHi;

storage/ndb/include/kernel/signaldata/DropFilegroup.hpp

+5 −3
Original line number Diff line number Diff line
@@ -66,7 +66,8 @@ struct DropFilegroupRef { 
    Busy = 701,

    NotMaster = 702,

    NoSuchFilegroup = 767,

    FilegroupInUse = 768

    FilegroupInUse = 768,

    InvalidSchemaObjectVersion = 774

  };

  

  Uint32 senderData;
@@ -150,7 +151,8 @@ struct DropFileRef { 
    NoError = 0,

    Busy = 701,

    NoSuchFile = 766,

    DropUndoFileNotSupported = 769

    DropUndoFileNotSupported = 769,

    InvalidSchemaObjectVersion = 774

  };



  Uint32 senderData;

storage/ndb/src/common/debugger/signaldata/DictTabInfo.cpp

+2 −2
Original line number Diff line number Diff line
@@ -216,8 +216,8 @@ SimpleProperties::SP2StructMapping 
DictFilegroupInfo::FileMapping[] = {

  DFGIMAPS(File, FileName, FileName, 0, PATH_MAX),

  DFGIMAP2(File, FileType, FileType, 0, 1),

  DFGIMAP(File, FileNo, FileNo),

  DFGIMAP(File, FileId, FileId),

  DFGIMAP(File, FileVersion, FileVersion),

  DFGIMAP(File, FileFGroupId, FilegroupId),

  DFGIMAP(File, FileFGroupVersion, FilegroupVersion),

  DFGIMAP(File, FileSizeHi, FileSizeHi),
@@ -254,8 +254,8 @@ void 
DictFilegroupInfo::File::init(){

  memset(FileName, sizeof(FileName), 0);

  FileType = ~0;

  FileNo = ~0;

  FileId = ~0;

  FileVersion = ~0;

  FilegroupId = ~0;

  FilegroupVersion = ~0;

  FileSizeHi = 0;

storage/ndb/src/kernel/blocks/dbdict/Dbdict.cpp

+17 −1
Original line number Diff line number Diff line
@@ -631,7 +631,8 @@ Dbdict::packFileIntoPages(SimpleProperties::Writer & w, 
  f.FileSizeHi = (f_ptr.p->m_file_size >> 32);

  f.FileSizeLo = (f_ptr.p->m_file_size & 0xFFFFFFFF);

  f.FileFreeExtents= free_extents;

  f.FileNo =  f_ptr.p->key;

  f.FileId =  f_ptr.p->key;

  f.FileVersion = f_ptr.p->m_version;



  FilegroupPtr lfg_ptr;

  ndbrequire(c_filegroup_hash.find(lfg_ptr, f.FilegroupId));
@@ -13588,6 +13589,13 @@ Dbdict::execDROP_FILE_REQ(Signal* signal) 
      break;

    }

    

    if (file_ptr.p->m_version != version)

    {

      ref->errorCode = DropFileRef::InvalidSchemaObjectVersion;

      ref->errorLine = __LINE__;

      break;

    }



    Ptr<SchemaTransaction> trans_ptr;

    if (! c_Trans.seize(trans_ptr))

    {
@@ -13663,6 +13671,13 @@ Dbdict::execDROP_FILEGROUP_REQ(Signal* signal) 
      break;

    }



    if (filegroup_ptr.p->m_version != version)

    {

      ref->errorCode = DropFilegroupRef::InvalidSchemaObjectVersion;

      ref->errorLine = __LINE__;

      break;

    }

    

    Ptr<SchemaTransaction> trans_ptr;

    if (! c_Trans.seize(trans_ptr))

    {
@@ -15095,6 +15110,7 @@ Dbdict::create_file_prepare_start(Signal* signal, SchemaOp* op){ 
    filePtr.p->m_obj_ptr_i = obj_ptr.i;

    filePtr.p->m_filegroup_id = f.FilegroupId;

    filePtr.p->m_type = f.FileType;

    filePtr.p->m_version = op->m_obj_version;

    

    obj_ptr.p->m_id = op->m_obj_id;

    obj_ptr.p->m_type = f.FileType;