Commit f9891381 authored by unknown's avatar unknown
Browse files

Fix for bug #10004 (Decimal operation crashes server) 


mysql-test/r/type_newdecimal.result:
  test result fixed
mysql-test/t/type_newdecimal.test:
  test case added
strings/decimal.c:
  old code didn't work when both decimals had zero before the decimal point
parent 0baed276

mysql-test/r/type_newdecimal.result

+3 −0
Original line number Diff line number Diff line
@@ -846,3 +846,6 @@ set sql_mode=''; 
select 0/0;

0/0

NULL

select 0.190287977636363637 + 0.040372670 * 0 -  0;

0.190287977636363637 + 0.040372670 * 0 -  0

0.190287977636363637

mysql-test/t/type_newdecimal.test

+5 −0
Original line number Diff line number Diff line
@@ -876,3 +876,8 @@ select 10.3330000000000/12.34500000; 


set sql_mode='';

select 0/0;



#

# Bug #10004

#

select 0.190287977636363637 + 0.040372670 * 0 -  0;

strings/decimal.c

+12 −8
Original line number Diff line number Diff line
@@ -1703,19 +1703,23 @@ static int do_sub(decimal_t *from1, decimal_t *from2, decimal_t *to) 
    carry=1;

  else if (intg2 == intg1)

  {

    while (unlikely(stop1[frac1-1] == 0))

      frac1--;

    while (unlikely(stop2[frac2-1] == 0))

      frac2--;

    while (buf1 < stop1+frac1 && buf2 < stop2+frac2 && *buf1 == *buf2)

    dec1 *end1= stop1 + (frac1 - 1);

    dec1 *end2= stop2 + (frac2 - 1);

    while (unlikely((buf1 <= end1) && (*end1 == 0)))

      end1--;

    while (unlikely((buf2 <= end2) && (*end2 == 0)))

      end2--;

    frac1= (end1 - stop1) + 1;

    frac2= (end2 - stop2) + 1;

    while (buf1 <=end1 && buf2 <= end2 && *buf1 == *buf2)

      buf1++, buf2++;

    if (buf1 < stop1+frac1)

      if (buf2 < stop2+frac2)

    if (buf1 <= end1)

      if (buf2 <= end2)

        carry= *buf2 > *buf1;

      else

        carry= 0;

    else

      if (buf2 < stop2+frac2)

      if (buf2 <= end2)

        carry=1;

      else /* short-circuit everything: from1 == from2 */

      {