Commit fa1d637e authored by unknown's avatar unknown
Browse files

A set of changes aiming to make the Event Scheduler more user-friendly 

when there are no up-to-date system tables to support it:
 - initialize the scheduler before reporting "Ready for connections".
   This ensures that warnings, if any, are printed before "Ready for
   connections", and this message is not mangled.
 - do not abort the scheduler if there are no system tables
 - check the tables once at start up, remember the status and disable
   the scheduler if the tables are not up to date.
   If one attempts to use the scheduler with bad tables,
   issue an error message.
 - clean up the behaviour of the module under LOCK TABLES and pre-locking
   mode
 - make sure implicit commit of Events DDL works as expected.
 - add more tests


Collateral clean ups in the events code.

This patch fixes Bug#23631 Events: SHOW VARIABLES doesn't work 
when mysql.event is damaged


mysql-test/r/events.result:
  Update results.
mysql-test/r/events_bugs.result:
  Update results.
mysql-test/r/events_restart_phase1.result:
  Update results.
mysql-test/r/events_restart_phase2.result:
  Update results.
mysql-test/r/events_restart_phase3.result:
  Update results.
mysql-test/r/events_scheduling.result:
  Update results.
mysql-test/r/events_time_zone.result:
  Update results.
mysql-test/t/events.test:
  Add new tests for tampering with mysql.event and some more
  tests for sub-statements, LOCK TABLES mode and pre-locking.
mysql-test/t/events_bugs.test:
  Move the non-concurrent part of test for Bug 16420 to this file.
mysql-test/t/events_restart_phase1.test:
  Rewrite events_restart_* tests to take into account that now
  we check mysql.event table only once, at server startup.
mysql-test/t/events_restart_phase2.test:
  Rewrite events_restart_* tests to take into account that now
  we check mysql.event table only once, at server startup.
mysql-test/t/events_restart_phase3.test:
  Rewrite events_restart_* tests to take into account that now
  we check mysql.event table only once, at server startup.
mysql-test/t/events_scheduling.test:
  Add more coverage for event_scheduler global variable.
mysql-test/t/events_time_zone.test:
  Move the non-concurrent part of the tests for Bug 16420 to 
  events_bugs.test
sql/event_data_objects.cc:
  Move update_timing_fields functionality to Event_db_repository.
  Make loading of events from a table record more robust to tampering
  with the table - now we do not check mysql.event on every table open.
sql/event_data_objects.h:
  Cleanup.
sql/event_db_repository.cc:
  Now Event_db_repository is responsible for table I/O only.
  All the logic of events DDL is handled outside, in Events class please
  refer to the added test coverage to see how this change affected
  the behavior of Event Scheduler.
  Dependency on sp_head.h and sp.h removed.
  Make this module robust to tweaks with mysql.event table.
  Move check_system_tables from events.cc to this file
sql/event_db_repository.h:
  Cleanup declarations (remove unused ones, change return type to bool
  from int).
sql/event_queue.cc:
  Update to adapt to the new start up scheme of the Event Scheduler.
sql/event_queue.h:
  Cleanup declarations.
sql/event_scheduler.cc:
  Make all the error messages uniform:
  [SEVERITY] Event Scheduler: [user][schema.event] message
  Using append_identifier for error logging was an overkill - we may 
  need it only if the system character set may have NUL (null character)
  as part of a valid identifier, this is currently never the case, 
  whereas additional quoting did not look nice in the log.
sql/event_scheduler.h:
  Cleanup the headers.
sql/events.cc:
  Use a different start up procedure of Event Scheduler:
  - at start up, try to check the system tables first.
  If they are not up-to-date, disable the scheduler.
  - try to load all the active events. In case of a load error, abort
  start up.
  - do not parse an event on start up. Parsing only gives some information
  about event validity, but far not all.
  Consolidate the business logic of Events DDL in this module.
  Now opt_event_scheduler may change after start up and thus is protected
  by LOCK_event_metadata mutex.
sql/events.h:
  Use all-static-data-members approach to implement Singleton pattern.
sql/mysqld.cc:
  New invocation scheme of Events. Move some logic to events.cc.
  Initialize the scheduler before reporting "Ready for connections".
sql/set_var.cc:
  Clean up sys_var_thd_sql_mode::symbolic_mode_representation
  to work with a LEX_STRING.
  Move more logic related to @@events_scheduler global variable to Events
  module.
sql/set_var.h:
  Update declarations.
sql/share/errmsg.txt:
  If someone tampered with mysql.event table after the server has
  started we no longer give him/her a complete report what was actually 
  broken. Do not send the user to look at the error log in such case,
  as there is nothing there (check_table_intact is not executed).
sql/sp_head.cc:
  Update to a new declaration of 
  sys_var_thd_sql_mode::symbolic_mode_representation
sql/sql_db.cc:
  New invocation scheme of Events module.
sql/sql_parse.cc:
  Move more logic to Events module. Make sure that we are consistent
  in the way access rights are checked for Events DDL: always
  after committing the current transaction and checking the system tables.
sql/sql_show.cc:
  Update to the new declarations of 
  sys_var_thd_sql_mode::symbolic_mode_representation
sql/sql_test.cc:
  New invocation scheme of events.
sql/table.cc:
  mysql.event is a system table.
  Update check_table_intact to be concurrent, more verbose, and less smart.
sql/table.h:
  Add a helper method.
mysql-test/r/events_trans.result:
  New BitKeeper file ``mysql-test/r/events_trans.result''
mysql-test/t/events_trans.test:
  New BitKeeper file ``mysql-test/t/events_trans.test'':
  test cases for Event Scheduler that require a transactional
  storage engine.
parent fce72805

mysql-test/r/events.result

+354 −50
Original line number Diff line number Diff line 
create database if not exists events_test;

drop database if exists events_test;

drop database if exists db_x;

drop database if exists mysqltest_db2;

drop database if exists mysqltest_no_such_database;

create database events_test;

use events_test;

CREATE USER pauline@localhost;

CREATE DATABASE db_x;
@@ -223,72 +227,180 @@ drop event root19; 
drop event root20;

drop event ðóóò21;

set names latin1;

Create a test event. Only event metadata is relevant, 

the actual schedule and body are not.

CREATE EVENT intact_check ON SCHEDULE EVERY 10 HOUR DO SELECT "nothing";

SHOW EVENTS;

Db	Name	Definer	Time zone	Type	Execute at	Interval value	Interval field	Starts	Ends	Status

events_test	intact_check	root@localhost	SYSTEM	RECURRING	NULL	10	#	#	NULL	ENABLED

ALTER TABLE mysql.event ADD dummy INT FIRST;

SHOW EVENTS;

ERROR HY000: Column count of mysql.event is wrong. Expected 17, found 18. The table is probably corrupted

ALTER TABLE mysql.event DROP dummy, ADD dummy2 VARCHAR(64) FIRST;

SHOW EVENTS;

ERROR HY000: Column count of mysql.event is wrong. Expected 17, found 18. The table is probably corrupted

ALTER TABLE mysql.event DROP dummy2;

Try to alter mysql.event: the server should fail to load

event information after mysql.event was tampered with.



First, let's add a column to the end and make sure everything

works as before



ALTER TABLE mysql.event ADD dummy INT;

SHOW EVENTS;

Db	Name	Definer	Time zone	Type	Execute at	Interval value	Interval field	Starts	Ends	Status

events_test	intact_check	root@localhost	SYSTEM	RECURRING	NULL	10	#	#	NULL	ENABLED

SELECT event_name FROM INFORMATION_SCHEMA.events;

event_name

intact_check

SHOW CREATE EVENT intact_check;

Event	sql_mode	time_zone	Create Event

intact_check		SYSTEM	CREATE EVENT `intact_check` ON SCHEDULE EVERY 10 HOUR STARTS '#' ON COMPLETION NOT PRESERVE ENABLE DO SELECT "nothing"

DROP EVENT no_such_event;

ERROR HY000: Unknown event 'no_such_event'

CREATE EVENT intact_check_1 ON SCHEDULE EVERY 5 HOUR DO SELECT 5;

ALTER EVENT intact_check_1 ON SCHEDULE EVERY 8 HOUR DO SELECT 8;

ALTER EVENT intact_check_1 RENAME TO intact_check_2;

DROP EVENT intact_check_1;

ERROR HY000: Unknown event 'intact_check_1'

DROP EVENT intact_check_2;

DROP EVENT intact_check;

DROP DATABASE IF EXISTS mysqltest_no_such_database;

Warnings:

Note	1008	Can't drop database 'mysqltest_no_such_database'; database doesn't exist

CREATE DATABASE mysqltest_db2;

DROP DATABASE mysqltest_db2;

SELECT @@event_scheduler;

@@event_scheduler

OFF

SHOW VARIABLES LIKE 'event_scheduler';

Variable_name	Value

event_scheduler	OFF

SET GLOBAL event_scheduler=OFF;

ALTER TABLE mysql.event DROP dummy;

CREATE EVENT intact_check ON SCHEDULE EVERY 10 HOUR DO SELECT "nothing";



Now let's add a column to the first position: the server

expects to see event schema name there



ALTER TABLE mysql.event ADD dummy INT FIRST;

SHOW EVENTS;

ERROR HY000: Cannot load from mysql.event. The table is probably corrupted

SELECT event_name FROM INFORMATION_SCHEMA.events;

ERROR HY000: Cannot load from mysql.event. The table is probably corrupted

SHOW CREATE EVENT intact_check;

ERROR HY000: Unknown event 'intact_check'

DROP EVENT no_such_event;

ERROR HY000: Unknown event 'no_such_event'

CREATE EVENT intact_check_1 ON SCHEDULE EVERY 5 HOUR DO SELECT 5;

ERROR HY000: Cannot load from mysql.event. The table is probably corrupted

ALTER EVENT intact_check_1 ON SCHEDULE EVERY 8 HOUR DO SELECT 8;

ERROR HY000: Unknown event 'intact_check_1'

ALTER EVENT intact_check_1 RENAME TO intact_check_2;

ERROR HY000: Unknown event 'intact_check_1'

DROP EVENT intact_check_1;

ERROR HY000: Unknown event 'intact_check_1'

DROP EVENT intact_check_2;

ERROR HY000: Unknown event 'intact_check_2'

DROP EVENT intact_check;

ERROR HY000: Unknown event 'intact_check'

DROP DATABASE IF EXISTS mysqltest_no_such_database;

Warnings:

Note	1008	Can't drop database 'mysqltest_no_such_database'; database doesn't exist

CREATE DATABASE mysqltest_db2;

DROP DATABASE mysqltest_db2;

SELECT @@event_scheduler;

@@event_scheduler

OFF

SHOW VARIABLES LIKE 'event_scheduler';

Variable_name	Value

event_scheduler	OFF

SET GLOBAL event_scheduler=OFF;

Clean up

ALTER TABLE mysql.event DROP dummy;

DELETE FROM mysql.event;

CREATE EVENT intact_check ON SCHEDULE EVERY 10 HOUR DO SELECT "nothing";

Back up the table, further changes are not reversible

CREATE TABLE event_like LIKE mysql.event;

INSERT INTO event_like SELECT * FROM mysql.event;

ALTER TABLE mysql.event MODIFY db char(64) character set cp1251 default '';

SELECT event_name FROM INFORMATION_SCHEMA.EVENTS;

ERROR HY000: Cannot load from mysql.event. The table is probably corrupted. Please see the error log for details

ALTER TABLE mysql.event MODIFY db char(20) character set utf8 collate utf8_bin default '';

SHOW CREATE TABLE mysql.event;

Table	Create Table

event	CREATE TABLE `event` (

  `db` char(20) CHARACTER SET utf8 COLLATE utf8_bin NOT NULL DEFAULT '',

  `name` char(64) NOT NULL DEFAULT '',

  `body` longblob NOT NULL,

  `definer` char(77) CHARACTER SET utf8 COLLATE utf8_bin NOT NULL DEFAULT '',

  `execute_at` datetime DEFAULT NULL,

  `interval_value` int(11) DEFAULT NULL,

  `interval_field` enum('YEAR','QUARTER','MONTH','DAY','HOUR','MINUTE','WEEK','SECOND','MICROSECOND','YEAR_MONTH','DAY_HOUR','DAY_MINUTE','DAY_SECOND','HOUR_MINUTE','HOUR_SECOND','MINUTE_SECOND','DAY_MICROSECOND','HOUR_MICROSECOND','MINUTE_MICROSECOND','SECOND_MICROSECOND') DEFAULT NULL,

  `created` timestamp NOT NULL DEFAULT CURRENT_TIMESTAMP ON UPDATE CURRENT_TIMESTAMP,

  `modified` timestamp NOT NULL DEFAULT '0000-00-00 00:00:00',

  `last_executed` datetime DEFAULT NULL,

  `starts` datetime DEFAULT NULL,

  `ends` datetime DEFAULT NULL,

  `status` enum('ENABLED','DISABLED') NOT NULL DEFAULT 'ENABLED',

  `on_completion` enum('DROP','PRESERVE') NOT NULL DEFAULT 'DROP',

  `sql_mode` set('REAL_AS_FLOAT','PIPES_AS_CONCAT','ANSI_QUOTES','IGNORE_SPACE','NOT_USED','ONLY_FULL_GROUP_BY','NO_UNSIGNED_SUBTRACTION','NO_DIR_IN_CREATE','POSTGRESQL','ORACLE','MSSQL','DB2','MAXDB','NO_KEY_OPTIONS','NO_TABLE_OPTIONS','NO_FIELD_OPTIONS','MYSQL323','MYSQL40','ANSI','NO_AUTO_VALUE_ON_ZERO','NO_BACKSLASH_ESCAPES','STRICT_TRANS_TABLES','STRICT_ALL_TABLES','NO_ZERO_IN_DATE','NO_ZERO_DATE','INVALID_DATES','ERROR_FOR_DIVISION_BY_ZERO','TRADITIONAL','NO_AUTO_CREATE_USER','HIGH_NOT_PRECEDENCE') NOT NULL DEFAULT '',

  `comment` char(64) CHARACTER SET utf8 COLLATE utf8_bin NOT NULL DEFAULT '',

  `time_zone` char(64) CHARACTER SET latin1 NOT NULL DEFAULT 'SYSTEM',

  PRIMARY KEY (`db`,`name`)

) ENGINE=MyISAM DEFAULT CHARSET=utf8 COMMENT='Events'

SELECT event_name FROM INFORMATION_SCHEMA.EVENTS;

ERROR HY000: Cannot load from mysql.event. The table is probably corrupted. Please see the error log for details

ALTER TABLE mysql.event MODIFY db char(64) character set utf8 collate utf8_bin default '';

"This should work"

SHOW EVENTS;

Db	Name	Definer	Time zone	Type	Execute at	Interval value	Interval field	Starts	Ends	Status

events_test	intact_check	root@localhost	SYSTEM	RECURRING	NULL	10	#	#	NULL	ENABLED

ALTER TABLE mysql.event MODIFY db char(64) character set cp1251 default '';

SELECT event_name FROM INFORMATION_SCHEMA.EVENTS;

ERROR HY000: Cannot load from mysql.event. The table is probably corrupted. Please see the error log for details

ALTER TABLE mysql.event MODIFY db varchar(64) character set utf8 collate utf8_bin default '';

SELECT event_name FROM INFORMATION_SCHEMA.EVENTS;

ERROR HY000: Cannot load from mysql.event. The table is probably corrupted. Please see the error log for details



Drop some columns and try more checks. 





ALTER TABLE mysql.event DROP comment, DROP starts;

SHOW EVENTS;

ERROR HY000: Cannot load from mysql.event. The table is probably corrupted

SELECT event_name FROM INFORMATION_SCHEMA.EVENTS;

ERROR HY000: Cannot load from mysql.event. The table is probably corrupted

SHOW CREATE EVENT intact_check;

ERROR HY000: Cannot load from mysql.event. The table is probably corrupted

DROP EVENT no_such_event;

ERROR HY000: Unknown event 'no_such_event'

CREATE EVENT intact_check_1 ON SCHEDULE EVERY 5 HOUR DO SELECT 5;

ERROR HY000: Column count of mysql.event is wrong. Expected 17, found 15. The table is probably corrupted

ALTER EVENT intact_check_1 ON SCHEDULE EVERY 8 HOUR DO SELECT 8;

ERROR HY000: Unknown event 'intact_check_1'

ALTER EVENT intact_check_1 RENAME TO intact_check_2;

ERROR HY000: Unknown event 'intact_check_1'

DROP EVENT intact_check_1;

ERROR HY000: Unknown event 'intact_check_1'

DROP EVENT intact_check_2;

ERROR HY000: Unknown event 'intact_check_2'

DROP EVENT intact_check;

DROP DATABASE IF EXISTS mysqltest_no_such_database;

Warnings:

Note	1008	Can't drop database 'mysqltest_no_such_database'; database doesn't exist

CREATE DATABASE mysqltest_db2;

DROP DATABASE mysqltest_db2;

SELECT @@event_scheduler;

@@event_scheduler

OFF

SHOW VARIABLES LIKE 'event_scheduler';

Variable_name	Value

event_scheduler	OFF

SET GLOBAL event_scheduler=OFF;



Now drop the table, and test again





DROP TABLE mysql.event;

SHOW EVENTS;

ERROR 42S02: Table 'mysql.event' doesn't exist

SELECT event_name FROM INFORMATION_SCHEMA.events;

ERROR 42S02: Table 'mysql.event' doesn't exist

SHOW CREATE EVENT intact_check;

ERROR 42S02: Table 'mysql.event' doesn't exist

DROP EVENT no_such_event;

ERROR 42S02: Table 'mysql.event' doesn't exist

CREATE EVENT intact_check_1 ON SCHEDULE EVERY 5 HOUR DO SELECT 5;

ERROR 42S02: Table 'mysql.event' doesn't exist

ALTER EVENT intact_check_1 ON SCHEDULE EVERY 8 HOUR DO SELECT 8;

ERROR 42S02: Table 'mysql.event' doesn't exist

ALTER EVENT intact_check_1 RENAME  TO intact_check_2;

ERROR 42S02: Table 'mysql.event' doesn't exist

DROP EVENT intact_check_1;

ERROR 42S02: Table 'mysql.event' doesn't exist

DROP EVENT intact_check_2;

ERROR 42S02: Table 'mysql.event' doesn't exist

DROP EVENT intact_check;

ERROR 42S02: Table 'mysql.event' doesn't exist

DROP DATABASE IF EXISTS mysqltest_no_such_database;

Warnings:

Note	1008	Can't drop database 'mysqltest_no_such_database'; database doesn't exist

Error	1146	Table 'mysql.event' doesn't exist

CREATE DATABASE mysqltest_db2;

DROP DATABASE mysqltest_db2;

OK, there is an unnecessary warning about the non-existent table 

but it's not easy to fix and no one complained about it.

A similar warning is printed if mysql.proc is missing.

SHOW WARNINGS;

Level	Code	Message

Error	1146	Table 'mysql.event' doesn't exist

SELECT @@event_scheduler;

@@event_scheduler

OFF

SHOW VARIABLES LIKE 'event_scheduler';

Variable_name	Value

event_scheduler	OFF

SET GLOBAL event_scheduler=OFF;

Restore the original table.

CREATE TABLE mysql.event like event_like;

INSERT INTO  mysql.event SELECT * FROM event_like;

DROP TABLE event_like;

SHOW EVENTS;

Db	Name	Definer	Time zone	Type	Execute at	Interval value	Interval field	Starts	Ends	Status

events_test	intact_check	root@localhost	SYSTEM	RECURRING	NULL	10	#	#	NULL	ENABLED

DROP EVENT intact_check;

create event e_26 on schedule at '2017-01-01 00:00:00' disable do set @a = 5;

select db, name, body, definer, convert_tz(execute_at, 'UTC', 'SYSTEM'), on_completion from mysql.event;

db	name	body	definer	convert_tz(execute_at, 'UTC', 'SYSTEM')	on_completion
@@ -401,4 +513,196 @@ SHOW EVENTS FROM ``; 
ERROR 42000: Incorrect database name ''

SHOW EVENTS FROM `events\\test`;

Db	Name	Definer	Time zone	Type	Execute at	Interval value	Interval field	Starts	Ends	Status



LOCK TABLES mode.



create table t1 (a int);

create event e1 on schedule every 10 hour do select 1;

lock table t1 read;

show create event e1;

Event	sql_mode	time_zone	Create Event

e1		SYSTEM	CREATE EVENT `e1` ON SCHEDULE EVERY 10 HOUR STARTS '#' ON COMPLETION NOT PRESERVE ENABLE DO select 1

select event_name from information_schema.events;

event_name

e1

create event e2 on schedule every 10 hour do select 1;

ERROR HY000: Table 'event' was not locked with LOCK TABLES

alter event e2 disable;

ERROR HY000: Table 'event' was not locked with LOCK TABLES

alter event e2 rename to e3;

ERROR HY000: Table 'event' was not locked with LOCK TABLES

drop event e2;

ERROR HY000: Table 'event' was not locked with LOCK TABLES

drop event e1;

ERROR HY000: Table 'event' was not locked with LOCK TABLES

unlock tables;

lock table t1 write;

show create event e1;

Event	sql_mode	time_zone	Create Event

e1		SYSTEM	CREATE EVENT `e1` ON SCHEDULE EVERY 10 HOUR STARTS '#' ON COMPLETION NOT PRESERVE ENABLE DO select 1

select event_name from information_schema.events;

event_name

e1

create event e2 on schedule every 10 hour do select 1;

ERROR HY000: Table 'event' was not locked with LOCK TABLES

alter event e2 disable;

ERROR HY000: Table 'event' was not locked with LOCK TABLES

alter event e2 rename to e3;

ERROR HY000: Table 'event' was not locked with LOCK TABLES

drop event e2;

ERROR HY000: Table 'event' was not locked with LOCK TABLES

drop event e1;

ERROR HY000: Table 'event' was not locked with LOCK TABLES

unlock tables;

lock table t1 read, mysql.event read;

show create event e1;

Event	sql_mode	time_zone	Create Event

e1		SYSTEM	CREATE EVENT `e1` ON SCHEDULE EVERY 10 HOUR STARTS '#' ON COMPLETION NOT PRESERVE ENABLE DO select 1

select event_name from information_schema.events;

event_name

e1

create event e2 on schedule every 10 hour do select 1;

ERROR HY000: Table 'event' was locked with a READ lock and can't be updated

alter event e2 disable;

ERROR HY000: Table 'event' was locked with a READ lock and can't be updated

alter event e2 rename to e3;

ERROR HY000: Table 'event' was locked with a READ lock and can't be updated

drop event e2;

ERROR HY000: Table 'event' was locked with a READ lock and can't be updated

drop event e1;

ERROR HY000: Table 'event' was locked with a READ lock and can't be updated

unlock tables;

lock table t1 write, mysql.event read;

show create event e1;

Event	sql_mode	time_zone	Create Event

e1		SYSTEM	CREATE EVENT `e1` ON SCHEDULE EVERY 10 HOUR STARTS '#' ON COMPLETION NOT PRESERVE ENABLE DO select 1

select event_name from information_schema.events;

event_name

e1

create event e2 on schedule every 10 hour do select 1;

ERROR HY000: Table 'event' was locked with a READ lock and can't be updated

alter event e2 disable;

ERROR HY000: Table 'event' was locked with a READ lock and can't be updated

alter event e2 rename to e3;

ERROR HY000: Table 'event' was locked with a READ lock and can't be updated

drop event e2;

ERROR HY000: Table 'event' was locked with a READ lock and can't be updated

drop event e1;

ERROR HY000: Table 'event' was locked with a READ lock and can't be updated

unlock tables;

lock table t1 read, mysql.event write;

ERROR HY000: You can't combine write-locking of system tables with other tables or lock types

lock table t1 write, mysql.event write;

ERROR HY000: You can't combine write-locking of system tables with other tables or lock types

lock table mysql.event write;

show create event e1;

Event	sql_mode	time_zone	Create Event

e1		SYSTEM	CREATE EVENT `e1` ON SCHEDULE EVERY 10 HOUR STARTS '#' ON COMPLETION NOT PRESERVE ENABLE DO select 1

select event_name from information_schema.events;

event_name

e1

create event e2 on schedule every 10 hour do select 1;

alter event e2 disable;

alter event e2 rename to e3;

drop event e3;

drop event e1;

unlock tables;

Make sure we have left no events 

select event_name from information_schema.events;

event_name



Events in sub-statements, events and prelocking





create event e1 on schedule every 10 hour do select 1;

create function f1() returns int

begin

show create event e1;

return 1;

end|

ERROR 0A000: Not allowed to return a result set from a function

create trigger trg before insert on t1 for each row

begin

show create event e1;

end|

ERROR 0A000: Not allowed to return a result set from a trigger

create function f1() returns int

begin

select event_name from information_schema.events;

return 1;

end|

ERROR 0A000: Not allowed to return a result set from a function

create trigger trg before insert on t1 for each row

begin

select event_name from information_schema.events;

end|

ERROR 0A000: Not allowed to return a result set from a trigger

create function f1() returns int

begin

create event e2 on schedule every 10 hour do select 1;

return 1;

end|

ERROR HY000: Recursion of EVENT DDL statements is forbidden when body is present

create function f1() returns int

begin

alter event e1 rename to e2;

return 1;

end|

ERROR HY000: Explicit or implicit commit is not allowed in stored function or trigger.

create function f1() returns int

begin

drop event e2;

return 1;

end|

ERROR HY000: Explicit or implicit commit is not allowed in stored function or trigger.

----------------------------------------------------------------------

create trigger trg before insert on t1 for each row

begin

set new.a= f1();

end|

create function f1() returns int

begin

call p1();

return 0;

end|

create procedure p1()

begin

select event_name from information_schema.events;

end|

insert into t1 (a) values (1)|

ERROR 0A000: Not allowed to return a result set from a trigger

drop procedure p1|

create procedure p1()

begin

show create event e1; 

end|

insert into t1 (a) values (1)|

ERROR 0A000: Not allowed to return a result set from a trigger

drop procedure p1|

create procedure p1()

begin

create temporary table tmp select event_name from information_schema.events;

end|

expected to work, since we redirect the output into a tmp table

insert into t1 (a) values (1)|

select * from tmp|

event_name

e1

drop temporary table tmp|

drop procedure p1|

create procedure p1()

begin

alter event e1 rename to e2;

end|

insert into t1 (a) values (1)|

ERROR HY000: Explicit or implicit commit is not allowed in stored function or trigger.

drop procedure p1|

create procedure p1()

begin

drop event e1;

end|

insert into t1 (a) values (1)|

ERROR HY000: Explicit or implicit commit is not allowed in stored function or trigger.

drop table t1|

drop event e1|

drop database events_test;

mysql-test/r/events_bugs.result

+149 −1

File changed.

Preview size limit exceeded, changes collapsed.

mysql-test/r/events_restart_phase1.result

+13 −9
Original line number Diff line number Diff line 
create database if not exists mysqltest_events_test;

use mysqltest_events_test;

set global event_scheduler=off;

drop database if exists events_test;

create database events_test;

use events_test;

create table execution_log(name char(10));

create event abc1 on schedule every 1 second do insert into execution_log value('abc1');

create event abc2 on schedule every 1 second do insert into execution_log value('abc2');

create event abc3 on schedule every 1 second do insert into execution_log value('abc3');

select name from execution_log;

name

insert into mysql.event values ('db1','bad','select 42','root@localhost',NULL,1000,'MICROSECOND','2006-05-05 17:39:11','2006-05-05 17:39:20','2016-05-05 15:39:24','2016-05-05 15:39:11',NULL,'ENABLED','DROP','','comment1','SYSTEM');

insert into mysql.event values ('db1','bad2','sect','root@localhost',NULL,1000,'SECOND','2006-05-05 17:39:11','2006-05-05 17:39:20','2016-05-05 15:39:24','2016-05-05 15:39:11',NULL,'ENABLED','DROP','','comment2','SYSTEM');

create event abc1 on schedule every 1 second do

insert into execution_log value('abc1');

create event abc2 on schedule every 1 second do

insert into execution_log value('abc2');

create event abc3 on schedule every 1 second do 

insert into execution_log value('abc3');

create table event_like like mysql.event;

insert into event_like select * from mysql.event;

alter table mysql.event

change column body  body longtext character set utf8 collate utf8_bin;

"Now we restart the server"

mysql-test/r/events_restart_phase2.result

+42 −6
Original line number Diff line number Diff line 
use mysqltest_events_test;

"Should get 0 rows because the queue aborted run

select distinct name from execution_log order by name;

name

delete from mysql.event where name like 'bad%';

"Now restart the server again"
 
use events_test;

select @@event_scheduler;

@@event_scheduler

DISABLED

show events;

ERROR HY000: Cannot proceed because system tables used by Event Scheduler were found damaged at server start

select event_name from information_schema.events;

ERROR HY000: Cannot proceed because system tables used by Event Scheduler were found damaged at server start

show create event intact_check;

ERROR HY000: Cannot proceed because system tables used by Event Scheduler were found damaged at server start

drop event no_such_event;

ERROR HY000: Cannot proceed because system tables used by Event Scheduler were found damaged at server start

create event intact_check_1 on schedule every 5 hour do select 5;

ERROR HY000: Cannot proceed because system tables used by Event Scheduler were found damaged at server start

alter event intact_check_1 on schedule every 8 hour do select 8;

ERROR HY000: Cannot proceed because system tables used by Event Scheduler were found damaged at server start

alter event intact_check_1 rename to intact_check_2;

ERROR HY000: Cannot proceed because system tables used by Event Scheduler were found damaged at server start

drop event intact_check_1;

ERROR HY000: Cannot proceed because system tables used by Event Scheduler were found damaged at server start

drop event intact_check_2;

ERROR HY000: Cannot proceed because system tables used by Event Scheduler were found damaged at server start

drop event intact_check;

ERROR HY000: Cannot proceed because system tables used by Event Scheduler were found damaged at server start

set global event_scheduler=on;

ERROR HY000: Cannot proceed because system tables used by Event Scheduler were found damaged at server start

set global event_scheduler=off;

ERROR HY000: Cannot proceed because system tables used by Event Scheduler were found damaged at server start

show variables like 'event_scheduler';

Variable_name	Value

event_scheduler	DISABLED

Make sure that we still can create and drop databases,

and no warnings are produced.

drop database if exists mysqltest_database_not_exists;

Warnings:

Note	1008	Can't drop database 'mysqltest_database_not_exists'; database doesn't exist

create database mysqltest_db1;

drop database mysqltest_db1;

Restore the original mysql.event table

drop table mysql.event;

rename table event_like to mysql.event;

Now let's restart the server again

mysql-test/r/events_restart_phase3.result

+5 −5
Original line number Diff line number Diff line 
use mysqltest_events_test;

use events_test;

select @@event_scheduler;

@@event_scheduler

ON

"Should get 3 rows : abc1, abc2, abc3

select distinct name from execution_log order by name;

name

abc1

abc2

abc3

drop event abc1;

drop event abc2;

drop event abc3;

drop table execution_log;

drop database mysqltest_events_test;
 
drop database events_test;