Commit faa5f3e0 authored by unknown's avatar unknown
Browse files

BUG#16002: Make partition functions that are unsigned work properly 


mysql-test/r/partition.result:
  A number of new test cases for unsigned partition functions
mysql-test/r/partition_error.result:
  A number of new test cases for unsigned partition functions
mysql-test/r/partition_range.result:
  A number of new test cases for unsigned partition functions
mysql-test/t/partition.test:
  A number of new test cases for unsigned partition functions
mysql-test/t/partition_error.test:
  A number of new test cases for unsigned partition functions
mysql-test/t/partition_range.test:
  A number of new test cases for unsigned partition functions
sql/ha_partition.cc:
  Error message for no partition found needs to take signed/unsigned into account when printing erroneus value
sql/partition_element.h:
  Introduced signed_flag and max_value flag on partition elements
  Also list is now a list of a struct rather than simply longlong values
  Small rearranges of order
sql/partition_info.cc:
  Introduced signed_flag and max_value flag on partition elements
  Also list is now a list of a struct rather than simply longlong values
  Small rearranges of order
  Lots of new code to handle checks of proper definition of table when
  partition function is unsigned
sql/partition_info.h:
  Mostly rearrangement of code and some addition of a THD object in check_partition_info call
  plus a new method for comparing unsigned values
sql/share/errmsg.txt:
  Negative values not ok for unsigned partition functions
sql/sql_partition.cc:
  Fixed a multi-thread bug (when defining several partitioned tables in parallel)
  New code to generate partition syntax that takes into account sign of constants.
  Made function fix_fields_part_func more reusable.
  Fixed a number of get_partition_id functions for range and list and similar functions
  for partition pruning code.
  Unfortunately fairly much duplication of code with just small changes.
sql/sql_partition.h:
  New function headers
sql/sql_show.cc:
  Changed list of values for LIST partitioned tables
  Also fixed printing of unsigned values in INFORMATION SCHEMA for partitioned table
sql/sql_table.cc:
  Fixed for new interface
sql/sql_yacc.yy:
  Moved definition of struct to partition_element.h
  Added code to keep track of sign of constants in
  RANGE and LIST partitions
sql/table.cc:
  Fixed for new interface
parent a514095a

mysql-test/r/partition.result

+20 −0
Original line number Diff line number Diff line 
drop table if exists t1;

create table t1 (a bigint unsigned);

insert into t1 values (0xFFFFFFFFFFFFFFFD);

insert into t1 values (0xFFFFFFFFFFFFFFFE);

select * from t1 where (a + 1) < 10;

a

select * from t1 where (a + 1) > 10;

a

18446744073709551613

18446744073709551614

drop table t1;

CREATE TABLE t1 (

a int not null,

b int not null,
@@ -839,4 +849,14 @@ SHOW TABLE STATUS; 
Name	Engine	Version	Row_format	Rows	Avg_row_length	Data_length	Max_data_length	Index_length	Data_free	Auto_increment	Create_time	Update_time	Check_time	Collation	Checksum	Create_options	Comment

t1	MyISAM	10	Dynamic	0	0	0	0	0	0	NULL	NULL	NULL	NULL	latin1_swedish_ci	NULL	partitioned	

DROP TABLE t1;

create table t1 (a bigint unsigned)

partition by list (a)

(partition p0 values in (0-1));

ERROR HY000: Partition function is unsigned, cannot have negative constants

create table t1 (a bigint unsigned)

partition by range (a)

(partition p0 values less than (10));

insert into t1 values (0xFFFFFFFFFFFFFFFF);

ERROR HY000: Table has no partition for value 18446744073709551615

drop table t1;

End of 5.1 tests

mysql-test/r/partition_error.result

+4 −0
Original line number Diff line number Diff line
@@ -554,3 +554,7 @@ PARTITION BY RANGE (a) (PARTITION p1 VALUES LESS THAN(5)); 
insert into t1 values (10);

ERROR HY000: Table has no partition for value 10

drop table t1;

create table t1 (a bigint unsigned)

partition by range (a)

(partition p0 values less than (-1));

ERROR HY000: Partition function is unsigned, cannot have negative constants

mysql-test/r/partition_range.result

+12 −0
Original line number Diff line number Diff line
@@ -363,3 +363,15 @@ SELECT COUNT(*) FROM t1 WHERE c3 < '2000-12-31'; 
COUNT(*)

10

DROP TABLE t1;

create table t1 (a bigint unsigned)

partition by range (a)

(partition p0 values less than (0),

partition p1 values less than (10));

ERROR HY000: VALUES LESS THAN value must be strictly increasing for each partition

create table t1 (a bigint unsigned)

partition by range (a)

(partition p0 values less than (2),

partition p1 values less than (10));

insert into t1 values (0xFFFFFFFFFFFFFFFF);

ERROR HY000: Table has no partition for value 18446744073709551615

drop table t1;

mysql-test/t/partition.test

+23 −0
Original line number Diff line number Diff line
@@ -9,6 +9,13 @@ 
drop table if exists t1;

--enable_warnings



create table t1 (a bigint unsigned);

insert into t1 values (0xFFFFFFFFFFFFFFFD);

insert into t1 values (0xFFFFFFFFFFFFFFFE);

select * from t1 where (a + 1) < 10;

select * from t1 where (a + 1) > 10;

drop table t1;



#

# Partition by key no partition defined => OK

#
@@ -956,4 +963,20 @@ PARTITION p2 VALUES LESS THAN (30) ENGINE = MyISAM); 
SHOW TABLE STATUS;

DROP TABLE t1;



#

#BUG 16002 Erroneus handling of unsigned partition functions

#

--error ER_SIGNED_PARTITION_CONSTANT_ERROR

create table t1 (a bigint unsigned)

partition by list (a)

(partition p0 values in (0-1));



create table t1 (a bigint unsigned)

partition by range (a)

(partition p0 values less than (10));



--error ER_NO_PARTITION_FOR_GIVEN_VALUE

insert into t1 values (0xFFFFFFFFFFFFFFFF);

drop table t1;



--echo End of 5.1 tests

mysql-test/t/partition_error.test

+5 −0
Original line number Diff line number Diff line
@@ -747,3 +747,8 @@ CREATE TABLE t1(a int) 
--error ER_NO_PARTITION_FOR_GIVEN_VALUE

insert into t1 values (10);

drop table t1;



--error ER_SIGNED_PARTITION_CONSTANT_ERROR

create table t1 (a bigint unsigned)

partition by range (a)

(partition p0 values less than (-1));